From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Bartosz Markowski <bartosz.markowski@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] ath10k: fix vdev map size for 10.x firmware
Date: Mon, 2 Jun 2014 19:42:51 +0300 [thread overview]
Message-ID: <87ppirz2ic.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1401370567-13543-1-git-send-email-bartosz.markowski@tieto.com> (Bartosz Markowski's message of "Thu, 29 May 2014 15:36:07 +0200")
Bartosz Markowski <bartosz.markowski@tieto.com> writes:
> Firmware 10.x supports up to 8 virtual AP interfaces
> (comparing to 7 for main firmware). Previous vdev map
> initialization was missing enough space for 8 + 1 vdevs
> (we may spent one for mac monitor), due to wrong define used.
>
> Use correct one - TARGET_10X_NUM_VDEVS - for 10.x firmware.
>
> Signed-off-by: Bartosz Markowski <bartosz.markowski@tieto.com>
So what is the actual bug you are fixing? Previously with 10.x it was
possible to get only 7 VIFs, even though we advertised 8 to user space,
and with your fix we get the full 8 VIFs?
It would be good to clear have that in the commit log so that anyone can
understand what bug is fixed.
--
Kalle Valo
next prev parent reply other threads:[~2014-06-02 16:42 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-29 13:36 [PATCH] ath10k: fix vdev map size for 10.x firmware Bartosz Markowski
2014-05-29 13:47 ` Ben Greear
2014-05-29 14:10 ` Bartosz Markowski
2014-05-29 14:42 ` Bartosz Markowski
2014-05-29 15:57 ` Ben Greear
2014-06-02 16:42 ` Kalle Valo [this message]
2014-06-02 17:11 ` Bartosz Markowski
2014-06-02 17:28 ` Kalle Valo
2014-06-02 18:24 ` Bartosz Markowski
2014-06-02 18:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppirz2ic.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=bartosz.markowski@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).