From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath10k: make core registering async
Date: Thu, 22 May 2014 19:42:41 +0300 [thread overview]
Message-ID: <87ppj5wyri.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1400767955-16313-3-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Thu, 22 May 2014 16:12:35 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> If ath10k was built into the kernel it could stall
> booting for 120 seconds by default (60 seconds for
> each firmware API variant) waiting for firmware
> files before userspace was ready or filesystems
> mounted.
>
> Fix this by making the core registering
> asynchronous.
>
> This also shoves off about 1 second from boot time
> on most systems since the driver is now mostly
> initialized in a worker and modprobe takes very
> little time to complete.
>
> As a side effect there's no way to propagate
> registering errors to the pci subsystem but this
> probably isn't really necessary.
>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
[...]
> --- a/drivers/net/wireless/ath/ath10k/pci.c
> +++ b/drivers/net/wireless/ath/ath10k/pci.c
> @@ -2758,8 +2758,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev)
> if (!ar_pci)
> return;
>
> - tasklet_kill(&ar_pci->msi_fw_err);
Why this? That's not obvious to me.
--
Kalle Valo
next prev parent reply other threads:[~2014-05-22 16:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 14:12 [PATCH 0/2] ath10k: async pci probing Michal Kazior
2014-05-22 14:12 ` [PATCH 1/2] ath10k: relocate core create/destroy functions Michal Kazior
2014-05-22 14:12 ` [PATCH 2/2] ath10k: make core registering async Michal Kazior
2014-05-22 14:41 ` Johannes Berg
2014-05-23 7:08 ` Michal Kazior
2014-06-23 10:19 ` Michal Kazior
2014-06-23 11:51 ` Johannes Berg
2014-06-23 12:17 ` Michal Kazior
2014-06-23 12:32 ` Johannes Berg
2014-06-23 12:59 ` Michal Kazior
2014-06-23 14:10 ` Johannes Berg
2014-05-22 16:40 ` Kalle Valo
2014-05-23 7:09 ` Michal Kazior
2014-05-22 16:42 ` Kalle Valo [this message]
2014-05-23 7:13 ` Michal Kazior
2014-05-23 7:16 ` Kalle Valo
2014-05-23 10:28 ` [PATCH 0/3] ath10k: async pci probing Michal Kazior
2014-05-23 10:28 ` [PATCH v2 1/3] ath10k: relocate core create/destroy functions Michal Kazior
2014-05-23 10:28 ` [PATCH v2 2/3] ath10k: remove unnecessary tasklet_kill() Michal Kazior
2014-05-23 10:28 ` [PATCH v2 3/3] ath10k: make core registering async Michal Kazior
2014-05-26 9:45 ` [PATCH 0/3] ath10k: async pci probing Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppj5wyri.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).