From: "Zhao\, Gang" <gamerh2o@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: wireless: Kconfig: add missing dependency for airo_cs
Date: Tue, 11 Mar 2014 12:01:04 +0800 [thread overview]
Message-ID: <87pplt9yf3.fsf@will.lan> (raw)
In-Reply-To: <1398887.G3HYkOfaVN@wuerfel> (Arnd Bergmann's message of "Mon, 10 Mar 2014 15:05:25 +0100")
On Mon, 2014-03-10 at 22:05:25 +0800, Arnd Bergmann wrote:
> commit 4c59ff221e070 "wireless: Kconfig: add missing dependency" added a number
> of 'depends on CFG80211' statements, but missed the AIRO_CS driver that
> also causes the airo.c file to be built. This adds the (hopefully) last
> such missing statement
Thanks for the catch.
minor issue: commit log should be 'fails to be built'.
>
> Cc: "Zhao, Gang" <gamerh2o@gmail.com>
> Cc: "John W. Linville" <linville@tuxdriver.com>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig
> index d1fab43..9c2c285 100644
> --- a/drivers/net/wireless/Kconfig
> +++ b/drivers/net/wireless/Kconfig
> @@ -116,7 +116,7 @@ config AT76C50X_USB
>
> config AIRO_CS
> tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards"
> - depends on PCMCIA && (BROKEN || !M32R)
> + depends on CFG80211 && PCMCIA && (BROKEN || !M32R)
> select WIRELESS_EXT
> select WEXT_SPY
> select WEXT_PRIV
prev parent reply other threads:[~2014-03-11 4:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 14:05 wireless: Kconfig: add missing dependency for airo_cs Arnd Bergmann
2014-03-11 4:01 ` Zhao, Gang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pplt9yf3.fsf@will.lan \
--to=gamerh2o@gmail.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).