From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pa0-f48.google.com ([209.85.220.48]:50684 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751389AbaCKEBQ (ORCPT ); Tue, 11 Mar 2014 00:01:16 -0400 From: "Zhao\, Gang" To: Arnd Bergmann Cc: "John W. Linville" , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: wireless: Kconfig: add missing dependency for airo_cs References: <1398887.G3HYkOfaVN@wuerfel> Date: Tue, 11 Mar 2014 12:01:04 +0800 In-Reply-To: <1398887.G3HYkOfaVN@wuerfel> (Arnd Bergmann's message of "Mon, 10 Mar 2014 15:05:25 +0100") Message-ID: <87pplt9yf3.fsf@will.lan> (sfid-20140311_050140_777496_27F24A62) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2014-03-10 at 22:05:25 +0800, Arnd Bergmann wrote: > commit 4c59ff221e070 "wireless: Kconfig: add missing dependency" added a number > of 'depends on CFG80211' statements, but missed the AIRO_CS driver that > also causes the airo.c file to be built. This adds the (hopefully) last > such missing statement Thanks for the catch. minor issue: commit log should be 'fails to be built'. > > Cc: "Zhao, Gang" > Cc: "John W. Linville" > Signed-off-by: Arnd Bergmann > --- > diff --git a/drivers/net/wireless/Kconfig b/drivers/net/wireless/Kconfig > index d1fab43..9c2c285 100644 > --- a/drivers/net/wireless/Kconfig > +++ b/drivers/net/wireless/Kconfig > @@ -116,7 +116,7 @@ config AT76C50X_USB > > config AIRO_CS > tristate "Cisco/Aironet 34X/35X/4500/4800 PCMCIA cards" > - depends on PCMCIA && (BROKEN || !M32R) > + depends on CFG80211 && PCMCIA && (BROKEN || !M32R) > select WIRELESS_EXT > select WEXT_SPY > select WEXT_PRIV