Linux wireless drivers development
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>,
	Sujith Manoharan <c_manoha@qca.qualcomm.com>,
	<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] ath10k: Fix bug in max. VHT A-MPDU size
Date: Mon, 7 Oct 2013 19:33:35 +0300	[thread overview]
Message-ID: <87pprht50g.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1380874630-14280-2-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 4 Oct 2013 10:17:09 +0200")

Michal Kazior <michal.kazior@tieto.com> writes:

> From: Sujith Manoharan <c_manoha@qca.qualcomm.com>
>
> For VHT peers, the maximum A-MPDU size has to be calculated
> from the VHT capabilities element and not the HT-cap. The formula
> is the same, but a higher value is used in VHT, allowing larger
> aggregates to be transmitted.
>
> The patch contains a workaround for some Netgear/Linksys APs that
> report Rx A-MPDU factor incorrectly.
>
> Signed-off-by: Sujith Manoharan <c_manoha@qca.qualcomm.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>

I see warnings with this patch:

drivers/net/wireless/ath/ath10k/mac.c: In function 'ath10k_peer_assoc_h_vht':
drivers/net/wireless/ath/ath10k/mac.c:1049:179: warning: comparison of distinct pointer types lacks a cast [enabled by default]
drivers/net/wireless/ath/ath10k/mac.c:1049:30: error: incompatible types in comparison expression (different signedness)
drivers/net/wireless/ath/ath10k/mac.c:1042: WARNING: line over 80 characters

-- 
Kalle Valo

  reply	other threads:[~2013-10-07 16:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <to=1380292567-2363-1-git-send-email-michal.kazior@tieto.com>
2013-10-04  8:17 ` [PATCH v2 0/2] ath10k: wep & ampdu fix Michal Kazior
2013-10-04  8:17   ` [PATCH v2 1/2] ath10k: Fix bug in max. VHT A-MPDU size Michal Kazior
2013-10-07 16:33     ` Kalle Valo [this message]
2013-10-04  8:17   ` [PATCH v2 2/2] ath10k: fix scheduling while atomic bug Michal Kazior
2013-10-07 16:35     ` Kalle Valo
2013-10-07 16:31   ` [PATCH v2 0/2] ath10k: wep & ampdu fix Kalle Valo
2013-10-08  2:51   ` [PATCH v3 " Michal Kazior
2013-10-08  2:51     ` [PATCH v3 1/2] ath10k: Fix bug in max. VHT A-MPDU size Michal Kazior
2013-10-08  2:51     ` [PATCH v3 2/2] ath10k: fix scheduling while atomic bug Michal Kazior
2013-10-08 18:58     ` [PATCH v3 0/2] ath10k: wep & ampdu fix Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pprht50g.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@qca.qualcomm.com \
    --cc=ath10k@lists.infradead.org \
    --cc=c_manoha@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=michal.kazior@tieto.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox