From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <linux-wireless@vger.kernel.org>, <ath10k@lists.infradead.org>
Subject: Re: [RFC 3/3] ath10k: add support for HTT 3.0
Date: Thu, 8 Aug 2013 12:42:46 +0300 [thread overview]
Message-ID: <87ppto1pt5.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQnsH6XxpgoBh0tTNCjXvNz-fL6OaCp=LP-Eap_4tqYNkw@mail.gmail.com> (Michal Kazior's message of "Thu, 8 Aug 2013 11:29:15 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 8 August 2013 11:22, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> On 8 August 2013 11:05, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>>
>>>> This debug print is good to have, but with the new htt version it would
>>>> be good to print it always using the info level. For example, can we add
>>>> it to the same line with "firmware %s booted" string?
>>>
>>> HTT target version is not known when firmware boots up. It's not known
>>> until everything other (HTC, WMI) is set up. We then send a version
>>> request command and we get a response.
>>
>> Oh, missed that.
>>
>>> We need to print it in a separate line.
>>
>> Or could we print the "firmware booted" message later?
>
> I'm worried it may be error-prone in case of firmware loading failure
> in-between (i.e. firmware is booted, but WMI init fails). We'd need to
> print the firmware version in the error path then.
True, let's just print in a separate line. We can worry about compacting
it later.
--
Kalle Valo
next prev parent reply other threads:[~2013-08-08 9:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-08 8:08 [RFC 0/3] ath10k: firmware-related updates Michal Kazior
2013-08-08 8:08 ` [RFC 1/3] ath10k: add support for firmware newer than 636 Michal Kazior
2013-08-08 8:46 ` Kalle Valo
2013-08-08 8:08 ` [RFC 2/3] ath10k: clean up HTT tx tid handling Michal Kazior
2013-08-08 8:08 ` [RFC 3/3] ath10k: add support for HTT 3.0 Michal Kazior
2013-08-08 9:05 ` Kalle Valo
2013-08-08 9:12 ` Michal Kazior
2013-08-08 9:22 ` Kalle Valo
2013-08-08 9:29 ` Michal Kazior
2013-08-08 9:42 ` Kalle Valo [this message]
2013-08-08 9:07 ` [RFC 0/3] ath10k: firmware-related updates Kalle Valo
2013-08-09 8:13 ` [PATCH " Michal Kazior
2013-08-09 8:13 ` [PATCH 1/3] ath10k: clean up HTT tx tid handling Michal Kazior
2013-08-15 13:07 ` Kalle Valo
2013-08-09 8:13 ` [PATCH 2/3] ath10k: add support for firmware newer than 636 Michal Kazior
2013-08-09 8:13 ` [PATCH 3/3] ath10k: add support for HTT 3.0 Michal Kazior
2013-08-15 13:10 ` Kalle Valo
2013-08-19 5:24 ` Michal Kazior
2013-08-15 13:09 ` [PATCH 0/3] ath10k: firmware-related updates Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ppto1pt5.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).