From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] ath10k: fix device teardown
Date: Mon, 5 Aug 2013 19:23:07 +0300 [thread overview]
Message-ID: <87pptsf6ok.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1375427747-9539-1-git-send-email-michal.kazior@tieto.com> (Michal Kazior's message of "Fri, 2 Aug 2013 09:15:47 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
> This fixes interrupt-related issue when no
> interfaces were running thus the device was
> considered powered down.
>
> The power_down() function isn't really powering
> down the device. It simply assumed it won't
> interrupt. This wasn't true in some cases and
> could lead to paging failures upon FW indication
> interrupt (i.e. FW crash) because some structures
> aren't allocated in that device state.
>
> One reason for that was that ar_pci->started
> wasn't reset. The other is interrupts should've
> been masked when teardown starts.
>
> The patch reorganized interrupt setup and makes
> sure ar_pci->started is reset accordingly.
>
> Reported-by: Ben Greear <greearb@candelatech.com>
> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
Thanks, applied.
--
Kalle Valo
prev parent reply other threads:[~2013-08-05 16:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 6:39 [PATCH] ath10k: move irq setup Michal Kazior
2013-07-30 18:35 ` Kalle Valo
2013-07-31 5:50 ` Michal Kazior
2013-07-31 10:50 ` Michal Kazior
2013-08-02 7:15 ` [PATCH v2] ath10k: fix device teardown Michal Kazior
2013-08-02 7:41 ` Kalle Valo
2013-08-02 7:51 ` Michal Kazior
2013-08-02 8:00 ` Kalle Valo
2013-08-05 16:23 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pptsf6ok.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).