Re: [RFC 1/3] mac80211: WIP - add operating BSSID to device configuration struct

[Kalle Valo <kalle.valo@iki.fi>]

Luciano Coelho <luciano.coelho@nokia.com> writes:

> ext Johannes Berg wrote:
>> On Fri, 2009-10-16 at 15:27 +0300, Luciano Coelho wrote:
>>
>>> +	if (memcmp(sdata->local->hw.conf.oper_bssid,
>>> +		   req->bss->bssid, ETH_ALEN)) {
>>> +		config_changed |= IEEE80211_CONF_CHANGE_OPER_BSSID;
>>> +		memcpy(sdata->local->hw.conf.oper_bssid,
>>> +		       req->bss->bssid, ETH_ALEN);
>>> +	}
>>> +
>>> +	ieee80211_hw_config(sdata->local, config_changed);
>>>  
>>
>> Is this really necessary before you can auth?
>
> As we discussed on IRC, it is really needed.  We must always provide a
> BSSID when changing channels in preparation for an association.

I'm not sure about the must part here. Maybe we can workaround it by
using ff:ff:ff:ff:ff bssid during authentication and association and
send a new join command after association. But that's not a clean
solution.

> Also, I'm not 100% sure, but IIRC Kalle has mentioned that the
> at76c50x-usb card also needs this feature.

Yeah, at76c50x-usb also has a similar requirement. wl1251, wl1271 and
at76c50x-usb have these weird join/start commands which need bssid and
must be executed before any data transmission. I tried to workaround
the bssid requirement in at76c50x-usb a long time ago but failed. I
need to try it again.

-- 
Kalle Valo