From: Kalle Valo <kalle.valo@nokia.com>
To: Bruno Randolf <bruno@thinktube.com>
Cc: ath5k-devel@lists.ath5k.org, mcgrof@gmail.com,
jirislaby@gmail.com, mickflemm@gmail.com,
linux-wireless@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH 1/2] ath5k: debug level improvements
Date: Mon, 21 Jan 2008 08:44:46 +0200 [thread overview]
Message-ID: <87prvvfzj5.fsf@nokia.com> (raw)
In-Reply-To: <20080121020924.3818.46553.stgit@one> (ext Bruno Randolf's message of "Mon\, 21 Jan 2008 11\:09\:24 +0900")
Bruno Randolf <bruno@thinktube.com> writes:
> @@ -209,7 +209,12 @@ static ssize_t write_file_tsf(struct file *file,
> size_t count, loff_t *ppos)
> {
> struct ath5k_softc *sc = file->private_data;
> - if (strncmp(userbuf, "reset", 5) == 0) {
> + char buf[20];
> +
> + if (copy_from_user(buf, userbuf, min_t(size_t, count, 20)))
> + return -EFAULT;
How about let the compiler count the size of buf? Like this:
if (copy_from_user(buf, userbuf, min_t(size_t, count, sizeof(buf))))
That way the size of buf is only in one place, and we might avoid a
bug whenever someone changes the size of buf.
> +static ssize_t read_file_debug(struct file *file, char __user *user_buf,
> + size_t count, loff_t *ppos)
> +{
> + struct ath5k_softc *sc = file->private_data;
> + char buf[1000];
To my eyes allocating 1000 bytes from stack is too large.
--
Kalle Valo
next prev parent reply other threads:[~2008-01-21 6:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-21 2:09 [PATCH 1/2] ath5k: debug level improvements Bruno Randolf
2008-01-21 2:09 ` [PATCH 2/2] ath5k: always extend rx timestamp with tsf Bruno Randolf
2008-01-21 2:16 ` Luis R. Rodriguez
2008-01-22 1:35 ` Nick Kossifidis
2008-01-21 6:44 ` Kalle Valo [this message]
2008-01-21 7:07 ` [PATCH 1/2] ath5k: debug level improvements bruno randolf
2008-01-21 7:20 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87prvvfzj5.fsf@nokia.com \
--to=kalle.valo@nokia.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=bruno@thinktube.com \
--cc=jirislaby@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mcgrof@gmail.com \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).