From: Kalle Valo <kvalo@kernel.org>
To: Ping-Ke Shih <pkshih@realtek.com>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Zong-Zhe Yang <kevin_yang@realtek.com>
Subject: Re: [PATCH v2 1/6] wifi: rtw89: 8922a: configure AP_LINK_PS if FW supports
Date: Wed, 20 Nov 2024 11:12:10 +0200 [thread overview]
Message-ID: <87r076z2tx.fsf@kernel.org> (raw)
In-Reply-To: <28b8c5c56c374a2da274f8d32b12f0da@realtek.com> (Ping-Ke Shih's message of "Wed, 20 Nov 2024 03:14:50 +0000")
Ping-Ke Shih <pkshih@realtek.com> writes:
> Kalle Valo <kvalo@kernel.org> wrote:
>
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>>
>> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
>> >
>> > After FW v0.35.46.0, for AP mode, RTL8922A FW supports a new FW feature,
>> > called NOTIFY_AP_INFO, to notify driver information related to AP mode.
>> > And, one function of it is to monitor PS states of remote stations. Once
>> > one of them changes, FW will send a C2H event to tell driver. With this
>> > FW feature, we can declare AP_LINK_PS.
>> >
>> > For now, driver still needs to determine if a frame is ps-poll or U-APSD
>> > trigger. So, add the corresponding RX handling in driver, which activates
>> > only when at least one AP is running.
>> >
>> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>>
>> [...]
>>
>> > +// CLASS 36 - SoftAP
>>
>> In wireless we prefer '/* */'.
>>
>
> The checkpatch is changed to allow this style by default, so I didn't catch
> the warning. Add option "--ignore C99_COMMENT_TOLERANCE" to my local script.
Oh, didn't know that. We should then add that to our ath12k-check script
as well.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2024-11-20 9:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-18 4:02 [PATCH v2 0/6] wifi: rtw89: preparation for MLO including AP_LINK_PS feature, ieee80211_ops and links Ping-Ke Shih
2024-11-18 4:02 ` [PATCH v2 1/6] wifi: rtw89: 8922a: configure AP_LINK_PS if FW supports Ping-Ke Shih
2024-11-18 12:34 ` Kalle Valo
2024-11-20 3:11 ` Ping-Ke Shih
2024-11-18 12:35 ` Kalle Valo
2024-11-20 3:14 ` Ping-Ke Shih
2024-11-20 9:12 ` Kalle Valo [this message]
2024-11-18 4:02 ` [PATCH v2 2/6] wifi: rtw89: register ops of can_activate_links Ping-Ke Shih
2024-11-18 4:02 ` [PATCH v2 3/6] wifi: rtw89: implement ops of change vif/sta links Ping-Ke Shih
2024-11-18 4:02 ` [PATCH v2 4/6] wifi: rtw89: apply MLD pairwise key to dynamically active links Ping-Ke Shih
2024-11-18 4:02 ` [PATCH v2 5/6] wifi: rtw89: pass target link_id to ieee80211_gtk_rekey_add() Ping-Ke Shih
2024-11-18 4:02 ` [PATCH v2 6/6] wifi: rtw89: pass target link_id to ieee80211_nullfunc_get() Ping-Ke Shih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r076z2tx.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=kevin_yang@realtek.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).