public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>
Cc: Baochen Qiang <quic_bqiang@quicinc.com>,
	 <ath12k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 00/10] wifi: ath12k: support suspend/resume
Date: Wed, 17 Apr 2024 17:22:43 +0300	[thread overview]
Message-ID: <87r0f4vzkc.fsf@kernel.org> (raw)
In-Reply-To: <aea9f68d-4862-439c-a52f-d6463e6edca9@quicinc.com> (Jeff Johnson's message of "Fri, 12 Apr 2024 11:05:00 -0700")

Jeff Johnson <quic_jjohnson@quicinc.com> writes:

> On 4/11/2024 11:06 PM, Baochen Qiang wrote:
>
>> Now that the MHI&QRTR patches [1] are merged, we can add
>> suspend/resume support for ath12k.
>> 
>> The whole design is quite similar to that in ath11k: firmware
>> is powered down when going to suspend and powered up when
>> resume, this makes hibernation work as well in addition to
>> suspend.
>> 
>> To summary, this series first does some preparations in the
>> first 8 patches. Then in patch [9/10] suspend/resume callbacks
>> are implemented. And at last in [10/10] we enable suspend/resume
>> functionality for WCN7850 because it's the only chip supporting
>> it for now.
>> 
>> [1] https://lore.kernel.org/linux-wireless/20240305021320.3367-1-quic_bqiang@quicinc.com/
>> 
>> Baochen Qiang (10):
>>   wifi: ath12k: rearrange IRQ enable/disable in reset path
>>   wifi: ath12k: remove MHI LOOPBACK channels
>>   wifi: ath12k: do not dump SRNG statistics during resume
>>   wifi: ath12k: fix warning on DMA ring capabilities event
>>   wifi: ath12k: decrease MHI channel buffer length to 8KB
>>   wifi: ath12k: flush all packets before suspend
>>   wifi: ath12k: no need to handle pktlog during suspend/resume
>>   wifi: ath12k: avoid stopping mac80211 queues in ath12k_core_restart()
>>   wifi: ath12k: support suspend/resume
>>   wifi: ath12k: change supports_suspend to true for WCN7850
>> 
>>  drivers/net/wireless/ath/ath12k/core.c  | 108 ++++++++++++++----------
>>  drivers/net/wireless/ath/ath12k/core.h  |   4 +
>>  drivers/net/wireless/ath/ath12k/dp_rx.c |  48 -----------
>>  drivers/net/wireless/ath/ath12k/dp_rx.h |   2 -
>
> My Qualcomm Innovation Center copyright checker reports:
> drivers/net/wireless/ath/ath12k/dp_rx.h copyright missing 2024

I fixed this in the pending branch:

https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/?h=pending&id=6b928df55a671d2c9a15edc746f6b42ef544928e

Jeff, what do you think of the patchset? Is it ready to take?

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  parent reply	other threads:[~2024-04-17 14:22 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12  6:06 [PATCH 00/10] wifi: ath12k: support suspend/resume Baochen Qiang
2024-04-12  6:06 ` [PATCH 01/10] wifi: ath12k: rearrange IRQ enable/disable in reset path Baochen Qiang
2024-04-12 18:24   ` Sidhanta Sahu
2024-04-15  5:38     ` Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-23  9:27   ` Kalle Valo
2024-04-12  6:06 ` [PATCH 02/10] wifi: ath12k: remove MHI LOOPBACK channels Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 03/10] wifi: ath12k: do not dump SRNG statistics during resume Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 04/10] wifi: ath12k: fix warning on DMA ring capabilities event Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 05/10] wifi: ath12k: decrease MHI channel buffer length to 8KB Baochen Qiang
2024-04-22 17:51   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 06/10] wifi: ath12k: flush all packets before suspend Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 07/10] wifi: ath12k: no need to handle pktlog during suspend/resume Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 08/10] wifi: ath12k: avoid stopping mac80211 queues in ath12k_core_restart() Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 09/10] wifi: ath12k: support suspend/resume Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12  6:06 ` [PATCH 10/10] wifi: ath12k: change supports_suspend to true for WCN7850 Baochen Qiang
2024-04-22 17:52   ` Jeff Johnson
2024-04-12 18:05 ` [PATCH 00/10] wifi: ath12k: support suspend/resume Jeff Johnson
2024-04-15  5:51   ` Baochen Qiang
2024-04-16  8:28     ` Kalle Valo
2024-04-16 10:31       ` Baochen Qiang
2024-04-17 14:22   ` Kalle Valo [this message]
2024-04-17 23:32     ` Jeff Johnson
2024-04-18  6:06       ` Jeff Johnson
2024-04-18 10:43         ` Baochen Qiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0f4vzkc.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=ath12k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_bqiang@quicinc.com \
    --cc=quic_jjohnson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox