From: Kalle Valo <kvalo@kernel.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Doug Brown <doug@schmorgal.com>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH 1/4] wifi: libertas: add missing calls to cancel_work_sync()
Date: Tue, 01 Aug 2023 13:23:21 +0300 [thread overview]
Message-ID: <87r0onxdra.fsf@kernel.org> (raw)
In-Reply-To: <ae49815a-c125-5a22-6757-b526d9712103@yandex.ru> (Dmitry Antipov's message of "Mon, 24 Jul 2023 11:57:12 +0300")
Dmitry Antipov <dmantipov@yandex.ru> writes:
> On 7/24/23 11:54, Kalle Valo wrote:
>
>> How have you tested these patches?
>>
>
> No physical hardware so compile tested only.
In that case please always add "Compile tested only" to the commit log.
It's important for us to know if a (non-trivial) patch is tested on a
real hardware or just with a compiler.
Another problem I see that you don't always reply to review comments and
that gives an impression that the comments are ignored. Please always
try to reply something to the review comments, even if just a simple
"ok" or "I don't agree because...".
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-08-01 10:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 8:44 [PATCH 1/4] wifi: libertas: add missing calls to cancel_work_sync() Dmitry Antipov
2023-07-24 8:44 ` [PATCH 2/4] wifi: libertas: use convenient lists to manage SDIO packets Dmitry Antipov
2023-07-24 8:44 ` [PATCH 3/4] wifi: libertas: simplify list operations in free_if_spi_card() Dmitry Antipov
2023-07-24 8:44 ` [PATCH 4/4] wifi: libertas: cleanup SDIO reset Dmitry Antipov
2023-07-24 8:54 ` [PATCH 1/4] wifi: libertas: add missing calls to cancel_work_sync() Kalle Valo
2023-07-24 8:57 ` Dmitry Antipov
2023-08-01 10:23 ` Kalle Valo [this message]
2023-08-01 11:47 ` Dmitry Antipov
2023-08-01 13:39 ` Kalle Valo
2023-08-01 14:02 ` Kalle Valo
2023-07-24 21:27 ` Dan Williams
2023-07-25 4:43 ` Dmitry Antipov
2023-07-25 6:04 ` [PATCH 1/6] [v2] " Dmitry Antipov
2023-07-25 6:04 ` [PATCH 2/6] [v2] wifi: libertas: use convenient lists to manage SDIO packets Dmitry Antipov
2023-07-25 6:04 ` [PATCH 3/6] [v2] wifi: libertas: simplify list operations in free_if_spi_card() Dmitry Antipov
2023-07-25 6:04 ` [PATCH 4/6] [v2] wifi: libertas: cleanup SDIO reset Dmitry Antipov
2023-07-25 6:04 ` [PATCH 5/6] [v2] wifi: libertas: handle possible spu_write_u16() errors Dmitry Antipov
2023-07-25 6:04 ` [PATCH 6/6] [v2] wifi: libertas: prefer kstrtoX() for simple integer conversions Dmitry Antipov
2023-07-31 13:25 ` [PATCH 1/6] [v2] wifi: libertas: add missing calls to cancel_work_sync() Dan Williams
2023-08-01 14:49 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0onxdra.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=dmantipov@yandex.ru \
--cc=doug@schmorgal.com \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).