From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0D61C0015E for ; Tue, 1 Aug 2023 10:26:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231271AbjHAK0n (ORCPT ); Tue, 1 Aug 2023 06:26:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44120 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233676AbjHAK0S (ORCPT ); Tue, 1 Aug 2023 06:26:18 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9D1115B96 for ; Tue, 1 Aug 2023 03:23:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6E79E61521 for ; Tue, 1 Aug 2023 10:23:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DB814C433C8; Tue, 1 Aug 2023 10:23:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690885404; bh=c929dygUnOm1BSbok++ltvpLIUzEv2S+5RUbs/24cKE=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=SZBNNn/j7jmUXjAWXZ5tNVLUas80puBbv1YOyXZTIIqdLY3gDQDyCZN5zcVg2GU5a GZ0KnfJDBO68CukcGuQaPwVNrY5We4NDrCfpNiCCgL+ly5cZGybUa27+/cGWEJra/e YOnJHOQ6HtgXvcPb9ohpoDA8iRqTnXtsVffKfAqdNhAQQruTxDnHa+sBonwTBS7OyA CP+O7/MnTjcPH0bTHZM+9ns4L6fB5IcME9w6n0oyrXw+nWUPBpu8qQIdnkAtEVHzA0 +URNxwbRCIEZFZnpx/KqS6ldUoJdmlFgaXxu7MvZjuZzJGc/S4W1FRKFSYfOR6i3o1 ACwTWBUiBGMzg== From: Kalle Valo To: Dmitry Antipov Cc: Doug Brown , linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org Subject: Re: [PATCH 1/4] wifi: libertas: add missing calls to cancel_work_sync() References: <20230724084457.64995-1-dmantipov@yandex.ru> <87cz0h3d1q.fsf@kernel.org> Date: Tue, 01 Aug 2023 13:23:21 +0300 In-Reply-To: (Dmitry Antipov's message of "Mon, 24 Jul 2023 11:57:12 +0300") Message-ID: <87r0onxdra.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Dmitry Antipov writes: > On 7/24/23 11:54, Kalle Valo wrote: > >> How have you tested these patches? >> > > No physical hardware so compile tested only. In that case please always add "Compile tested only" to the commit log. It's important for us to know if a (non-trivial) patch is tested on a real hardware or just with a compiler. Another problem I see that you don't always reply to review comments and that gives an impression that the comments are ignored. Please always try to reply something to the review comments, even if just a simple "ok" or "I don't agree because...". -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches