From: Kalle Valo <kvalo@kernel.org>
To: <Ajay.Kathat@microchip.com>
Cc: <dmantipov@yandex.ru>, <Amisha.Patel@microchip.com>,
<linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] wifi: wilc1000: simplify TX callback functions
Date: Tue, 25 Jul 2023 18:08:35 +0300 [thread overview]
Message-ID: <87r0ow111o.fsf@kernel.org> (raw)
In-Reply-To: <df4db7fe-b51d-5eba-dd9d-527753903eac@microchip.com> (Ajay Kathat's message of "Thu, 13 Jul 2023 21:33:46 +0000")
<Ajay.Kathat@microchip.com> writes:
> Hi Dmitry,
>
> On 7/13/23 01:26, Dmitry Antipov wrote:
>> EXTERNAL EMAIL: Do not click links or open attachments unless you
>> know the content is safe
>>
>> Drop unused second argument of TX callback functions and use
>> 'struct txq_entry_t *' as the only argument, thus removing
>> 'struct wilc_p2p_mgmt_data', 'struct tx_complete_mon_data'
>> and 'struct tx_complete_data' (actually intended just to
>> pass callbacks parameters) as well. This also shrinks
>> 'struct txq_entry_t' by 'priv' field and eliminates a few
>> 'kmalloc()/kfree()' calls (at the cost of having dummy
>> stack-allocated 'struct txq_entry_t' instances).
>
> I'm just curious to know if you have tested this patch with the real
> hardware.
There was no response from Dmitry but I suspect this was not tested on a
real device. Submitting patches like this without any real testing is a
bad idea as the risk of regressions is high. Please _always_ test
patches on a real device. Only exception are trivial patches which can
be easily reviewed.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2023-07-25 15:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 8:26 [PATCH] wifi: wilc1000: simplify TX callback functions Dmitry Antipov
2023-07-13 21:33 ` Ajay.Kathat
2023-07-14 14:27 ` [PATCH] wifi: wilc1000: simplify and cleanup TX paths Dmitry Antipov
2023-07-14 23:05 ` Ajay.Kathat
2023-07-17 8:43 ` [PATCH] [v2] " Dmitry Antipov
2024-02-19 16:05 ` Kalle Valo
2023-07-25 15:08 ` Kalle Valo [this message]
2023-07-25 15:50 ` [PATCH] wifi: wilc1000: simplify TX callback functions Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r0ow111o.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=Ajay.Kathat@microchip.com \
--cc=Amisha.Patel@microchip.com \
--cc=dmantipov@yandex.ru \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).