From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C00A8C433FE for ; Thu, 17 Nov 2022 10:52:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239241AbiKQKwL (ORCPT ); Thu, 17 Nov 2022 05:52:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239414AbiKQKwC (ORCPT ); Thu, 17 Nov 2022 05:52:02 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A73FD15710 for ; Thu, 17 Nov 2022 02:52:01 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 41B2460AE3 for ; Thu, 17 Nov 2022 10:52:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D26D3C433C1; Thu, 17 Nov 2022 10:51:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1668682320; bh=Lb3Y8YZJzUYKLPeAx42l0VS1ZrHBX0qzfcpmMgcFksg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=WuxtpEEHZxQiN2bN2avjq3aFG7DBjG2XjKp5u6vzCuOw/GY6WVWTWY+rtRmp1AQum cNgdB62NPkY2NSd6mTILS/QwHGGh7ykhPWinz1KRQpJqCmPPH0ofowAEyMV23i4XzC STd31Es6A5DGFm1BBekrW9g+pn0+BJZqyuzNt8fJxsxAom2ioQOlHN2rhMdxRlSqZ/ O+dZXt6eOo00kFQrpDpJUlb6p1gf7F49du14iAZtwjsXW297I8zdnHmaFXV+Q9uiNI 6e4snZAmH35O6/WF0U9BPxxuGNv47f7jvy5dswiWrko19WIUF5/cXwOsdnQZN0mYCU eBx91yBMLzsRQ== From: Kalle Valo To: Johannes Berg Cc: linux-wireless@vger.kernel.org, Johannes Berg Subject: Re: [RFC PATCH 2/2] wifi: wireless: deny wireless extensions on MLO-capable devices References: <20221104174218.26f9541c0bfa.Ifcf30eeeb8fc7019e4dcf2782b04515254d165e1@changeid> <20221104174218.7817a3abaf39.Ib9eabc2ec5bf6b0244e4d973e93baaa3d8c91bd8@changeid> Date: Thu, 17 Nov 2022 12:51:57 +0200 In-Reply-To: <20221104174218.7817a3abaf39.Ib9eabc2ec5bf6b0244e4d973e93baaa3d8c91bd8@changeid> (Johannes Berg's message of "Fri, 4 Nov 2022 17:42:21 +0100") Message-ID: <87r0y1rgz6.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Johannes Berg writes: > From: Johannes Berg > > These are new devices that will be introduced into the market s/new/Wi-Fi 7/? > in 2023, with new drivers. Wireless extensions haven't been in > real development since 2006. Since wireless has evolved a lot, > and continues to evolve significantly with MLO, there's really s/MLO/Multi-Link Operation/? It would good to spell out the acronym at least once per commit log. > no good way to still support wireless extensions for devices > that do MLO. > > Stop supporting wireless extensions for new devices. We don't > consider this a regression since no such devices (apart from > hwsim) exist yet. > > Signed-off-by: Johannes Berg > --- > net/wireless/wext-core.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/net/wireless/wext-core.c b/net/wireless/wext-core.c > index cbeb8be214a8..d3b5cf02690c 100644 > --- a/net/wireless/wext-core.c > +++ b/net/wireless/wext-core.c > @@ -662,6 +662,8 @@ struct iw_statistics *get_wireless_stats(struct net_device *dev) > dev->ieee80211_ptr->wiphy->wext && > dev->ieee80211_ptr->wiphy->wext->get_wireless_stats) { > wireless_warn_cfg80211_wext(); > + if (dev->ieee80211_ptr->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO) > + return NULL; Should we have a some kind of warning in this case as well? Otherwise the user has no idea why it stopped working, right? > return dev->ieee80211_ptr->wiphy->wext->get_wireless_stats(dev); > } > #endif > @@ -702,6 +704,8 @@ static iw_handler get_handler(struct net_device *dev, unsigned int cmd) > #ifdef CONFIG_CFG80211_WEXT > if (dev->ieee80211_ptr && dev->ieee80211_ptr->wiphy) { > wireless_warn_cfg80211_wext(); > + if (dev->ieee80211_ptr->wiphy->flags & WIPHY_FLAG_SUPPORTS_MLO) > + return NULL; And here? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches