* [PATCH v2 0/1] wcn36xx: Revert firmware link monitoring
@ 2021-10-23 9:32 Bryan O'Donoghue
2021-10-23 9:32 ` [PATCH v2 1/1] Revert "wcn36xx: Enable firmware link monitoring" Bryan O'Donoghue
0 siblings, 1 reply; 3+ messages in thread
From: Bryan O'Donoghue @ 2021-10-23 9:32 UTC (permalink / raw)
To: kvalo, linux-wireless, wcn36xx
Cc: loic.poulain, benl, daniel.thompson, bryan.odonoghue
V2:
- Adds Fixes tag
V1:
We can get this working with
- Secure APs PS on/off
- Open APs PS on
by setting firmware feature bit WLANACTIVE_OFFLOAD
Open APs PS off though is non-functional even with the above bit enabled
and three quaters of a wheel is useless.
So unfortunately for now zap it off.
Bryan O'Donoghue (1):
Revert "wcn36xx: Enable firmware link monitoring"
drivers/net/wireless/ath/wcn36xx/main.c | 1 -
1 file changed, 1 deletion(-)
--
2.33.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2 1/1] Revert "wcn36xx: Enable firmware link monitoring"
2021-10-23 9:32 [PATCH v2 0/1] wcn36xx: Revert firmware link monitoring Bryan O'Donoghue
@ 2021-10-23 9:32 ` Bryan O'Donoghue
2021-10-25 8:58 ` Kalle Valo
0 siblings, 1 reply; 3+ messages in thread
From: Bryan O'Donoghue @ 2021-10-23 9:32 UTC (permalink / raw)
To: kvalo, linux-wireless, wcn36xx
Cc: loic.poulain, benl, daniel.thompson, bryan.odonoghue
This reverts commit c973fdad79f6eaf247d48b5fc77733e989eb01e1.
Fixes: c973fdad79f6 ("wcn36xx: Enable firmware link monitoring")
Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Signed-off-by: Benjamin Li <benl@squareup.com>
---
drivers/net/wireless/ath/wcn36xx/main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c
index dd8810fd76a3d..fd8b2753da7dd 100644
--- a/drivers/net/wireless/ath/wcn36xx/main.c
+++ b/drivers/net/wireless/ath/wcn36xx/main.c
@@ -1334,7 +1334,6 @@ static int wcn36xx_init_ieee80211(struct wcn36xx *wcn)
ieee80211_hw_set(wcn->hw, HAS_RATE_CONTROL);
ieee80211_hw_set(wcn->hw, SINGLE_SCAN_ON_ALL_BANDS);
ieee80211_hw_set(wcn->hw, REPORTS_TX_ACK_STATUS);
- ieee80211_hw_set(wcn->hw, CONNECTION_MONITOR);
wcn->hw->wiphy->interface_modes = BIT(NL80211_IFTYPE_STATION) |
BIT(NL80211_IFTYPE_AP) |
--
2.33.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-25 8:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-23 9:32 [PATCH v2 0/1] wcn36xx: Revert firmware link monitoring Bryan O'Donoghue
2021-10-23 9:32 ` [PATCH v2 1/1] Revert "wcn36xx: Enable firmware link monitoring" Bryan O'Donoghue
2021-10-25 8:58 ` Kalle Valo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).