From: Kalle Valo <kvalo@codeaurora.org>
To: kbuild test robot <lkp@intel.com>
Cc: Ping-Ke Shih <pkshih@realtek.com>,
kbuild-all@lists.01.org, Yan-Hsuan Chuang <yhchuang@realtek.com>,
linux-wireless@vger.kernel.org
Subject: Re: [wireless-drivers-next:master 41/48] drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse: symbol '__rtw_download_firmware' was not declared. Should it be static?
Date: Fri, 24 Apr 2020 12:45:49 +0300 [thread overview]
Message-ID: <87r1wdgqsy.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <202004241610.NSbGjIMy%lkp@intel.com> (kbuild test robot's message of "Fri, 24 Apr 2020 16:57:52 +0800")
+ linux-wireless
kbuild test robot <lkp@intel.com> writes:
> tree:
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.git
> master
> head: 75e69fb11b40ba1256b14f943c7050682c1f5458
> commit: 15d2fcc6b2dea46986e55cd3808c0dbb480a6c8d [41/48] rtw88: add
> legacy firmware download for 8723D devices
> reproduce:
> # apt-get install sparse
> # sparse version: v0.6.1-191-gc51a0382-dirty
> git checkout 15d2fcc6b2dea46986e55cd3808c0dbb480a6c8d
> make ARCH=x86_64 allmodconfig
> make C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__'
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@intel.com>
>
>
> sparse warnings: (new ones prefixed by >>)
>
>>> drivers/net/wireless/realtek/rtw88/mac.c:653:5: sparse: sparse:
>>> symbol '__rtw_download_firmware' was not declared. Should it be
>>> static?
>>> drivers/net/wireless/realtek/rtw88/mac.c:817:5: sparse: sparse:
>>> symbol '__rtw_download_firmware_legacy' was not declared. Should it
>>> be static?
>
> Please review and possibly fold the followup patch.
Tony, please send the patch via linux-wireless so that patchwork sees
it.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next parent reply other threads:[~2020-04-24 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <202004241610.NSbGjIMy%lkp@intel.com>
2020-04-24 9:45 ` Kalle Valo [this message]
2020-04-25 2:56 ` [RFC PATCH wireless-drivers-next] rtw88: __rtw_download_firmware() can be static kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r1wdgqsy.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pkshih@realtek.com \
--cc=yhchuang@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox