From: Kalle Valo <kvalo@codeaurora.org>
To: Luca Coelho <luca@coelho.fi>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH 07/12] iwlwifi: mvm: don't skip mgmt tid when flushing all tids
Date: Fri, 25 Oct 2019 11:04:56 +0300 [thread overview]
Message-ID: <87r231p7x3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <20191020085545.16407-6-luca@coelho.fi> (Luca Coelho's message of "Sun, 20 Oct 2019 11:55:40 +0300")
Luca Coelho <luca@coelho.fi> writes:
> From: Haim Dreyfuss <haim.dreyfuss@intel.com>
>
> There are various of flows which require tids flushing
> (disconnection, suspend, etc...).
> Currently, when the driver instructs the FW to flush
> he masks all the data tids(0-7).
> However, the driver doesn't set the management tid (#15)
> which cause the FW not to flush it.
> When the FW tries to remove the mgmt queue he throws an assert
> since it is not an empty queue.
> instead of just set only the data tids set everything and let
> the FW ignore the invalid tids.
>
> Signed-off-by: Haim Dreyfuss <haim.dreyfuss@intel.com>
> Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
[...]
> - ret = iwl_mvm_flush_sta_tids(mvm, flush_arg, 0xFF, 0) ? : count;
> + ret = iwl_mvm_flush_sta_tids(mvm, flush_arg, 0xFFFF, 0)
[...]
> - iwl_mvm_flush_sta_tids(mvm, i, 0xFF, 0);
> + iwl_mvm_flush_sta_tids(mvm, i, 0xFFFF, 0);
[...]
> - 0xff | BIT(IWL_MGMT_TID), flags);
> + 0xffff, flags);
If, instead of magic values, you had a proper define this would be a
simple change. Hint hint ;)
No need to change anything, but something to keep in mind.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2019-10-25 8:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-20 8:55 [PATCH 00/12] iwlwifi: updates intended for v5.5 2019-20 Luca Coelho
2019-10-20 8:55 ` [PATCH 01/12] iwlwifi: remove redundant assignment to variable bufsz Luca Coelho
2019-10-20 8:55 ` [PATCH 02/12] iwlwifi: mvm: fix unaligned read of rx_pkt_status Luca Coelho
2019-10-20 8:55 ` [PATCH 03/12] iwlwifi: scan: make new scan req versioning flow Luca Coelho
2019-10-20 14:41 ` [PATCH v2 " Luca Coelho
2019-10-20 8:55 ` [PATCH 04/12] iwlwifi: scan: support scan req cmd ver 12 Luca Coelho
2019-10-20 8:55 ` [PATCH 05/12] iwlwifi: refactor the SAR tables from mvm to acpi Luca Coelho
2019-10-20 8:55 ` [PATCH 06/12] iwlwifi: mvm: scan: enable adaptive dwell in p2p Luca Coelho
2019-10-20 8:55 ` [PATCH 07/12] iwlwifi: mvm: don't skip mgmt tid when flushing all tids Luca Coelho
2019-10-25 8:04 ` Kalle Valo [this message]
2019-10-20 8:55 ` [PATCH 08/12] iwlwifi: mvm: start CTDP budget from 2400mA Luca Coelho
2019-10-20 8:55 ` [PATCH 09/12] iwlwifi: mvm: sync the iwl_mvm_session_prot_notif layout Luca Coelho
2019-10-20 8:55 ` [PATCH 10/12] iwlwifi: remove IWL_DEVICE_22560/IWL_DEVICE_FAMILY_22560 Luca Coelho
2019-10-20 8:55 ` [PATCH 11/12] iwlwifi: 22000: fix some indentation Luca Coelho
2019-10-20 8:55 ` [PATCH 12/12] iwlwifi: mvm: fix non-ACPI function Luca Coelho
2020-01-23 4:02 ` Stable Backport Request: " Jiaxun Yang
2020-01-23 5:42 ` Jiaxun Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r231p7x3.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luca@coelho.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox