From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca
Date: Mon, 13 May 2019 07:26:21 +0300 [thread overview]
Message-ID: <87r293ugia.fsf@purkki.adurom.net> (raw)
In-Reply-To: <0691acb931e963cb6028d4687cdd61032d0aaf52.1557591530.git.lorenzo@kernel.org> (Lorenzo Bianconi's message of "Sat, 11 May 2019 18:38:41 +0200")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
> Introduce a knob in mt7603 debugfs in order to enable/disable
> edcca processing
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
It's good to explain what edcca does and how the file is used supposed
to be used. In other words, have a small introduction for the user.
> @@ -48,6 +77,7 @@ void mt7603_init_debugfs(struct mt7603_dev *dev)
> if (!dir)
> return;
>
> + debugfs_create_file("edcca", 0400, dir, dev, &fops_edcca);
Why 0400 and not 0600?
--
Kalle Valo
next prev parent reply other threads:[~2019-05-13 4:26 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1557591530.git.lorenzo@kernel.org>
2019-05-11 16:38 ` [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca Lorenzo Bianconi
2019-05-13 4:26 ` Kalle Valo [this message]
2019-05-13 8:41 ` Lorenzo Bianconi
2019-05-13 9:48 ` Stanislaw Gruszka
2019-05-15 9:33 ` Stanislaw Gruszka
2019-05-15 9:43 ` Lorenzo Bianconi
2019-05-15 9:54 ` Stanislaw Gruszka
2019-05-15 10:03 ` Lorenzo Bianconi
2019-05-15 10:33 ` Stanislaw Gruszka
2019-05-15 11:13 ` Lorenzo Bianconi
2019-05-15 11:46 ` Stanislaw Gruszka
2019-05-15 12:07 ` Lorenzo Bianconi
2019-05-15 13:48 ` Stanislaw Gruszka
2019-05-15 13:59 ` Stanislaw Gruszka
2019-05-13 12:37 ` Kalle Valo
2019-05-13 15:41 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r293ugia.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).