From: Kalle Valo <kvalo@codeaurora.org>
To: <pkshih@realtek.com>
Cc: <linux-wireless@vger.kernel.org>, <joe@perches.com>,
<rickveens92@gmail.com>, <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h
Date: Mon, 01 Oct 2018 12:10:36 +0300 [thread overview]
Message-ID: <87r2ha2fsj.fsf@codeaurora.org> (raw)
In-Reply-To: <20181001090424.13862-1-pkshih@realtek.com> (pkshih@realtek.com's message of "Mon, 1 Oct 2018 17:04:24 +0800")
<pkshih@realtek.com> writes:
> From: Rick Veens <rickveens92@gmail.com>
>
> The following:
> bool efuse_re_pg_sec1flag;
> u8 efuse_re_pg_data[8];
> are not referenced anywhere in the rtlwifi code.
>
> This patch is originally created by Rick Veens <rickveens92@gmail.com>,
> and Joe Perches <joe@perches.com> reminded to apply it to rtlwifi.
>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Rick's Signed-off-by is missing. Ping, either you need to mark yourself
as author (which IMHO is correct as you wrote this patch anyway, Rick
wrote it for the other driver) or Rick needs to give his s-o-b.
--
Kalle Valo
next prev parent reply other threads:[~2018-10-01 9:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-01 9:04 [PATCH] rtlwifi: Removed unused define and code efuse_re_pg* from wifi.h pkshih
2018-10-01 9:10 ` Kalle Valo [this message]
2018-10-01 9:24 ` Pkshih
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r2ha2fsj.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=pkshih@realtek.com \
--cc=rickveens92@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).