linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: "Reizer\, Eyal" <eyalr@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
	"linux-wireless\@vger.kernel.org"
	<linux-wireless@vger.kernel.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"sebastian.reichel\@collabora.co.uk"
	<sebastian.reichel@collabora.co.uk>,
	Julian Calaby <julian.calaby@gmail.com>
Subject: Re: [v6] wlcore: add missing nvs file name info for wilink8
Date: Thu, 10 Aug 2017 10:46:19 +0300	[thread overview]
Message-ID: <87r2wjeugk.fsf@codeaurora.org> (raw)
In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B36422C65@DFRE01.ent.ti.com> (Eyal Reizer's message of "Thu, 10 Aug 2017 06:35:46 +0000")

"Reizer, Eyal" <eyalr@ti.com> writes:

>> The fact that is old does not change a thing, we still need to
>> support it no matter what the data sheet and your system design
>> says. A fix that breaks other things is not really a fix :)
>> 
>
> Sure, just want to make sure we are not trying to add work around just for
> A couple of faulty devices.
>
>> > I have verified using a couple of com6 modules with an am335x-evm and
>> they had mac addresses read ok.
>> 
>> Sounds like there are multiple variants of the wl12xx
>> available then.
>> 
> I am trying to find out internally if there is a possibility that there were devices
> Produced in the past where the internal fuses were not programmed with a valid 
> Address before being assembled into the modules.

Just a general remark, based on my past experience, you can't really
know what hardware is out there, no matter how someone in the company
claims otherwise. Uncalibrated devices, prototypes and calibration data
broken are all possible and better be preparared for that in the driver.

It's a good idea at least to detect and print a proper error message if
the calibration data is broken. But if the data on the device only
consists of MAC address and nothing else, then I guess using a random
address is fine.

-- 
Kalle Valo

  reply	other threads:[~2017-08-10  7:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1502264840-10569-1-git-send-email-eyalr@ti.com>
2017-08-09  7:53 ` [v6] wlcore: add missing nvs file name info for wilink8 Reizer, Eyal
2017-08-09 17:26   ` Tony Lindgren
2017-08-09 17:28     ` Tony Lindgren
     [not found]     ` <ngx9scofrw0qb2vkesion8v9.1502300336052@email.android.com>
2017-08-09 21:16       ` Tony Lindgren
2017-08-10  6:35         ` Reizer, Eyal
2017-08-10  7:46           ` Kalle Valo [this message]
2017-08-10  7:59             ` Reizer, Eyal
2017-08-10  7:52           ` Julian Calaby
2017-08-10  7:56             ` Reizer, Eyal
2017-08-10 14:23         ` Reizer, Eyal
2017-08-10 17:26           ` Tony Lindgren
2017-08-13 13:07             ` Reizer, Eyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r2wjeugk.fsf@codeaurora.org \
    --to=kvalo@codeaurora.org \
    --cc=eyalr@ti.com \
    --cc=julian.calaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=sebastian.reichel@collabora.co.uk \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).