Re: [PATCH] wlcore: disable multicast filter in AP mode

[Kalle Valo <kvalo@codeaurora.org>]

Iain Hunter <drhunter95@gmail.com> writes:

> Enable AP support allmulticast for MDNS. It can be enabled by bringing up 
>
> the interface with ip command with the argument allmulticast on
>
> Signed-off-by: Iain Hunter <i-hunter1@ti.com>

The commit log looks now ok, except there's an unnecessare empty line.
But I can fix that.

> @@ -3281,6 +3281,20 @@ static void wl1271_op_configure_filter(struct ieee80211_hw *hw,
>  			if (ret < 0)
>  				goto out_sleep;
>  		}
> +
> +        /*
> +         * If interface in AP mode and created with allmulticast then disable
> +         * the firmware filters so that all multicast packets are passed
> +         * This is mandatory for MDNS based discovery protocols 
> +         */
> + 		if (wlvif->bss_type == BSS_TYPE_AP_BSS) {
> + 			if (*total & FIF_ALLMULTI)
> +				ret = wl1271_acx_group_address_tbl(wl, wlvif,
> +								   false,
> +								   NULL, 0);
> +              
> +                }
> +
>  	}

Sorry, I missed this earlier but here you don't check ret value at all.
I think you should bail out from the look if an error happens, like
other commands in the same loop does.

-- 
Kalle Valo