From: Kalle Valo <kvalo@codeaurora.org>
To: gavinli@thegavinli.com
Cc: arend.vanspriel@broadcom.com, franky.lin@broadcom.com,
hante.meuleman@broadcom.com, linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com, stable@vger.kernel.org,
Gavin Li <git@thegavinli.com>
Subject: Re: [PATCH] brcmfmac: fix incorrect event channel deduction
Date: Wed, 18 Jan 2017 12:27:25 +0200 [thread overview]
Message-ID: <87r340hdde.fsf@purkki.adurom.net> (raw)
In-Reply-To: <20170117231534.7099-1-gavinli@thegavinli.com> (gavinli@thegavinli.com's message of "Tue, 17 Jan 2017 15:15:34 -0800")
gavinli@thegavinli.com writes:
> From: Gavin Li <git@thegavinli.com>
>
> brcmf_sdio_fromevntchan() was being called on the the data frame
> rather than the software header, causing some frames to be
> mischaracterized as on the event channel rather than the data channel.
>
> This fixes a major performance regression (due to dropped packets).
>
> Fixes: c56caa9db8ab ("brcmfmac: screening firmware event packet")
> Signed-off-by: Gavin Li <git@thegavinli.com>
> Cc: <stable@vger.kernel.org> [4.7+]
In the future please add version to the subject so that maintainers can
easily find the latest version:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#subject
Arend, do you think this is safe enough for 4.10? Or better to get more
testing time and push this to 4.11 and from where to stable releases?
--
Kalle Valo
next prev parent reply other threads:[~2017-01-18 10:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 23:15 [PATCH] brcmfmac: fix incorrect event channel deduction gavinli
2017-01-18 10:27 ` Kalle Valo [this message]
2017-01-18 10:40 ` Kalle Valo
-- strict thread matches above, loose matches on Subject: below --
2017-01-17 22:55 gavinli
2017-01-17 23:09 ` Rafał Miłecki
2017-01-17 22:50 gavinli
2017-01-17 22:29 gavinli
2017-01-17 22:41 ` Rafał Miłecki
2017-01-17 22:41 ` Rafał Miłecki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r340hdde.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=franky.lin@broadcom.com \
--cc=gavinli@thegavinli.com \
--cc=git@thegavinli.com \
--cc=hante.meuleman@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox