From: Kalle Valo <kvalo@codeaurora.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jakub Kicinski <jakub.kicinski@netronome.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
David Miller <davem@davemloft.net>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dinan.gunawardena@netronome.com
Subject: Re: [RFC (v7)] add basic register-field manipulation macros
Date: Fri, 19 Aug 2016 12:09:47 +0300 [thread overview]
Message-ID: <87r39lyvj8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+55aFytOu02ZvRf+gxCCeP98qbv8wXzOds8Ocu-Ps4mKbGCkQ@mail.gmail.com> (Linus Torvalds's message of "Thu, 18 Aug 2016 10:28:01 -0700")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Thu, Aug 18, 2016 at 10:11 AM, Jakub Kicinski
> <jakub.kicinski@netronome.com> wrote:
>> Hi!
>>
>> This is what I came up with. Changes:
>
> I can live with this, certainly. I'm not really sure how many drivers
> (or perhaps core code, for that matter) will actually start using it,
> but it at least _looks_ like a usable interface that seems to be quite
> resistant to people doing stupid things with it that would result in
> surprising results (either performance or semantics).
I'm guessing that at least in ath9k and ath10k there would be use of
these macros.
> So I'm ok with something like this coming through (for example) the
> wireless tree if the drivers there are the first ones to start using
> this.
>
> Let's see if anybody else objects.
Great, thanks for the help. Let's wait for other comments and Jakub can
then resend this without RFC. I can then take it through my tree.
--
Kalle Valo
next prev parent reply other threads:[~2016-08-19 9:09 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-16 15:18 [PATCHv6 0/2] register-field manipulation macros Jakub Kicinski
2016-08-16 15:18 ` [PATCHv6 1/2] add basic " Jakub Kicinski
2016-08-17 10:31 ` Kalle Valo
2016-08-17 16:33 ` Linus Torvalds
2016-08-17 17:11 ` Jakub Kicinski
2016-08-17 17:16 ` Linus Torvalds
2016-08-18 17:11 ` [RFC (v7)] " Jakub Kicinski
2016-08-18 17:28 ` Linus Torvalds
2016-08-19 9:09 ` Kalle Valo [this message]
2016-08-16 15:18 ` [PATCHv6 2/2] mt7601u: use linux/bitfield.h Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r39lyvj8.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=dinan.gunawardena@netronome.com \
--cc=gregkh@linuxfoundation.org \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox