From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: <ath10k@lists.infradead.org>, <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 8/8] ath10k: finally kill htt_rx_info
Date: Mon, 24 Mar 2014 11:38:40 +0200 [thread overview]
Message-ID: <87r45s6in3.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1395394341-3958-9-git-send-email-janusz.dziedzic@tieto.com> (Janusz Dziedzic's message of "Fri, 21 Mar 2014 10:32:21 +0100")
Janusz Dziedzic <janusz.dziedzic@tieto.com> writes:
> Struct htt_rx_info is not needed anymore while
> we will use ieee80211_rx_status structure as
> as template.
>
> Signed-off-by: Janusz Dziedzic <janusz.dziedzic@tieto.com>
[...]
> -static void ath10k_process_rx(struct ath10k *ar, struct htt_rx_info *info)
> +static void ath10k_process_rx(struct ath10k *ar,
> + struct ieee80211_rx_status *rx_status,
> + struct sk_buff *skb)
> {
> struct ieee80211_rx_status *status;
>
> - status = IEEE80211_SKB_RXCB(info->skb);
> - memcpy(status, &info->rx_status, sizeof(*status));
> + status = IEEE80211_SKB_RXCB(skb);
> + memcpy(status, rx_status, sizeof(*status));
I guess you saw this suggestion from the buildbot:
>> drivers/net/wireless/ath/ath10k/htt_rx.c:803:1-7: Replace memcpy with struct assignment
--
Kalle Valo
prev parent reply other threads:[~2014-03-24 9:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-21 9:32 [PATCH 0/8] ath10k: refactor htt_rx path Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 1/8] ath10k: move rx related functions to htt_rx.c Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 2/8] ath10k: rename process_rx_rates to ath10k_htt_rx_h_rates Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 3/8] ath10k: introduce ieee80211_rx_status to htt_rx_info Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 4/8] ath10k: setup rx channel per ppdu Janusz Dziedzic
2014-03-24 8:56 ` Kalle Valo
2014-03-24 10:17 ` Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 5/8] ath10k: kill not needed fields from htt_rx_info Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 6/8] ath10k: return error when ath10k_htt_rx_amsdu_pop() fail Janusz Dziedzic
2014-03-21 9:32 ` [PATCH 7/8] ath10k: improve way we play with attention flags Janusz Dziedzic
2014-03-24 9:40 ` Kalle Valo
2014-03-21 9:32 ` [PATCH 8/8] ath10k: finally kill htt_rx_info Janusz Dziedzic
2014-03-24 9:38 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r45s6in3.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).