From: Kalle Valo <kalle.valo@iki.fi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 1/3 v2] mac80211: improve powersave implementation
Date: Thu, 16 Apr 2009 13:55:08 +0300 [thread overview]
Message-ID: <87r5zs98c3.fsf@litku.valot.fi> (raw)
In-Reply-To: <1239824326.29769.4.camel@johannes.local> (Johannes Berg's message of "Wed\, 15 Apr 2009 21\:38\:46 +0200")
Johannes Berg <johannes@sipsolutions.net> writes:
> When you have multiple virtual interfaces the current
> implementation requires setting them up properly from
> userspace, which is undesirable when we want to default
> to power save mode. Keep track of powersave requested
> from userspace per managed mode interface, and only
> enable powersave globally when exactly one managed mode
> interface is active and has powersave turned on.
>
> Second, only start the dynPS timer when PS is turned
> on, and properly turn it off when PS is turned off.
>
> Third, fix the scan_sdata abuse in the dynps code.
>
> Finally, also reorder the code and refactor the code
> that enables PS or the dynps timer instead of having
> it copied in two places.
The code is a lot cleaner now, thanks for doing this.
Unfortunately I don't have time to do proper review or testing right
now, but after a quick look this looks good.
--
Kalle Valo
next prev parent reply other threads:[~2009-04-16 10:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-15 17:10 [RFC 0/3] mac80211 powersave improvements Johannes Berg
2009-04-15 17:10 ` [RFC 1/3] mac80211: improve powersave implementation Johannes Berg
2009-04-15 19:38 ` [RFC 1/3 v2] " Johannes Berg
2009-04-16 10:55 ` Kalle Valo [this message]
2009-04-15 17:10 ` [RFC 2/3] mac80211: disable powersave if pm_qos asks for low latency Johannes Berg
2009-04-15 19:38 ` [RFC 2/3 v2] " Johannes Berg
2009-04-16 10:58 ` Kalle Valo
2009-04-15 17:10 ` [RFC 3/3] mac80211: enable PS by default Johannes Berg
2009-04-16 10:39 ` [RFC 3/3 v2] " Johannes Berg
2009-04-16 11:01 ` [RFC 0/3] mac80211 powersave improvements Kalle Valo
2009-04-16 11:06 ` Johannes Berg
2009-04-16 11:11 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r5zs98c3.fsf@litku.valot.fi \
--to=kalle.valo@iki.fi \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).