Re: [PATCH v6 3/3] mac80211: implement dynamic power save

[Kalle Valo <kalle.valo@nokia.com>]

Vivek Natarajan <vivek.natraj@gmail.com> writes:

> On Fri, Dec 19, 2008 at 11:47 AM, Vivek Natarajan
> <vivek.natraj@gmail.com> wrote:
>> On Fri, Dec 19, 2008 at 3:05 AM, Kalle Valo <kalle.valo@nokia.com> wrote:
>>> @@ -872,6 +878,9 @@ static void ieee80211_set_disassoc(struct ieee80211_sub_if_data *sdata,
>>>        local->oper_channel_type = NL80211_CHAN_NO_HT;
>>>        config_changed |= IEEE80211_CONF_CHANGE_HT;
>>>
>>> +       del_timer_sync(&local->dynamic_ps_timer);
>>> +       cancel_work_sync(&local->dynamic_ps_enable_work);
>>
>> In addition, shouldn't we have this 'cancel_work'  in ieee80211_stop
>> or where ever in the stop/detach path since the ps timer may be
>> triggered even after the interface is brought down.
>
> Sorry, ieee80211_set_disassoc is called from ieee80211_stop too...

Yeah, I got lucky. John fixed this a while ago.

-- 
Kalle Valo