linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: wcn7850 issues
       [not found]                           ` <LO0P123MB40578B26075CD4C9C66D144BD6932@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
@ 2024-09-03  7:47                             ` Kalle Valo
  2024-09-03  9:57                               ` Janusz Dziedzic
  0 siblings, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2024-09-03  7:47 UTC (permalink / raw)
  To: david Atkins; +Cc: Baochen Qiang, ath12k@lists.infradead.org, linux-wireless

+ linux-wireless

david Atkins <david@3adesign.co.uk> writes:

> ...
>> >>>         Ext Tag: EHT Operation (802.11be D3.0)
>> >>>             Ext Tag length: 8 (Tag len: 9)
>> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
>> >>>             EHT Operation Parameters: 0x01, EHT Operation Information
>> Present
>> >>>                 .... ...1 = EHT Operation Information Present: True
>> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
>> >>>                 .... .0.. = EHT Default PE Duration: False
>> >>>                 .... 0... = Group Addressed BU Indication Limit: False
>> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
>> >>>                 00.. .... = Reserved: 0x0
>> >>>             Basic EHT-MCS And Nss Set: 0x44444444
>> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS bandwidth
>> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth (2)
>> >>>                 0000 0... = Reserved: 0x00
>> >>>
>> >>> Are you saying the ath12k driver does not support these features? If
>> >>> not can
>> >> you clarify the issue so I can raise with the AP team.
>> >>>
>> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the AP
>> >> requires NSS to be no less than 4, that is why EHT connection was disabled.
>> >
>> > Which field is requiring NSS of 4, I'm only seeing a maximum of 4, the
>> Qualcomm windows driver will connect to the same AP, we had assumed that
>> that ath12k would do the same.
>> Basic EHT-MCS And Nss Set: 0x44444444
>
> My understanding of the spec is that there are maximum numbers of
> streams though, are you saying the AP has to advertise 0x22222222
> which would then prevent a 4x4 client (say an extender) from
> connecting with 4 streams? I note that the Qualcomm windows driver for
> Hamilton works with the AP and an Intel BE200 also works both of which
> will be in at most 2x2

Did you test Intel BE200 with the Windows driver? Johannes mentioned
that ieee80211_verify_sta_eht_mcs_support() in mac80211 checks this so I
would assume that iwlwifi also behaves like ath12k.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: wcn7850 issues
  2024-09-03  7:47                             ` wcn7850 issues Kalle Valo
@ 2024-09-03  9:57                               ` Janusz Dziedzic
  2024-09-03 10:07                                 ` Johannes Berg
  2024-09-03 10:09                                 ` Kalle Valo
  0 siblings, 2 replies; 8+ messages in thread
From: Janusz Dziedzic @ 2024-09-03  9:57 UTC (permalink / raw)
  To: Kalle Valo
  Cc: david Atkins, Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless

wt., 3 wrz 2024 o 09:47 Kalle Valo <kvalo@kernel.org> napisał(a):
>
> + linux-wireless
>
> david Atkins <david@3adesign.co.uk> writes:
>
> > ...
> >> >>>         Ext Tag: EHT Operation (802.11be D3.0)
> >> >>>             Ext Tag length: 8 (Tag len: 9)
> >> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
> >> >>>             EHT Operation Parameters: 0x01, EHT Operation Information
> >> Present
> >> >>>                 .... ...1 = EHT Operation Information Present: True
> >> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
> >> >>>                 .... .0.. = EHT Default PE Duration: False
> >> >>>                 .... 0... = Group Addressed BU Indication Limit: False
> >> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
> >> >>>                 00.. .... = Reserved: 0x0
> >> >>>             Basic EHT-MCS And Nss Set: 0x44444444
> >> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS bandwidth
> >> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth (2)
> >> >>>                 0000 0... = Reserved: 0x00
> >> >>>
> >> >>> Are you saying the ath12k driver does not support these features? If
> >> >>> not can
> >> >> you clarify the issue so I can raise with the AP team.
> >> >>>
> >> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the AP
> >> >> requires NSS to be no less than 4, that is why EHT connection was disabled.
> >> >
> >> > Which field is requiring NSS of 4, I'm only seeing a maximum of 4, the
> >> Qualcomm windows driver will connect to the same AP, we had assumed that
> >> that ath12k would do the same.
> >> Basic EHT-MCS And Nss Set: 0x44444444
> >
> > My understanding of the spec is that there are maximum numbers of
> > streams though, are you saying the AP has to advertise 0x22222222
> > which would then prevent a 4x4 client (say an extender) from
> > connecting with 4 streams? I note that the Qualcomm windows driver for
> > Hamilton works with the AP and an Intel BE200 also works both of which
> > will be in at most 2x2
>
> Did you test Intel BE200 with the Windows driver? Johannes mentioned
> that ieee80211_verify_sta_eht_mcs_support() in mac80211 checks this so I
> would assume that iwlwifi also behaves like ath12k.
>

Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
In other case station  < 4nss will drop to HE only.

BR
Janusz

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: wcn7850 issues
  2024-09-03  9:57                               ` Janusz Dziedzic
@ 2024-09-03 10:07                                 ` Johannes Berg
  2024-09-03 10:09                                 ` Kalle Valo
  1 sibling, 0 replies; 8+ messages in thread
From: Johannes Berg @ 2024-09-03 10:07 UTC (permalink / raw)
  To: Janusz Dziedzic, Kalle Valo
  Cc: david Atkins, Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless

> 
> Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
> 

You probably don't even want 0x11111111, that would require all MCSes,
which some stations might not support.

Since some things are mandatory, I'm not sure I see a lot of value in
advertising anything non-zero, certainly not by default, and only set it
if specifically want to require something in the BSS that's _not_
already otherwise mandatory.

I mean, maybe you do want to require 4 NSS and all MCSes like the
0x44444444 does, so that regular clients cannot connect ;)

johannes

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: wcn7850 issues
  2024-09-03  9:57                               ` Janusz Dziedzic
  2024-09-03 10:07                                 ` Johannes Berg
@ 2024-09-03 10:09                                 ` Kalle Valo
  2024-09-03 21:15                                   ` david Atkins
  1 sibling, 1 reply; 8+ messages in thread
From: Kalle Valo @ 2024-09-03 10:09 UTC (permalink / raw)
  To: Janusz Dziedzic
  Cc: david Atkins, Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless

Janusz Dziedzic <janusz.dziedzic@gmail.com> writes:

> wt., 3 wrz 2024 o 09:47 Kalle Valo <kvalo@kernel.org> napisał(a):
>>
>> + linux-wireless
>>
>> david Atkins <david@3adesign.co.uk> writes:
>>
>> > ...
>> >> >>>         Ext Tag: EHT Operation (802.11be D3.0)
>> >> >>>             Ext Tag length: 8 (Tag len: 9)
>> >> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
>> >> >>>             EHT Operation Parameters: 0x01, EHT Operation Information
>> >> Present
>> >> >>>                 .... ...1 = EHT Operation Information Present: True
>> >> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
>> >> >>>                 .... .0.. = EHT Default PE Duration: False
>> >> >>>                 .... 0... = Group Addressed BU Indication Limit: False
>> >> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
>> >> >>>                 00.. .... = Reserved: 0x0
>> >> >>>             Basic EHT-MCS And Nss Set: 0x44444444
>> >> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS bandwidth
>> >> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth (2)
>> >> >>>                 0000 0... = Reserved: 0x00
>> >> >>>
>> >> >>> Are you saying the ath12k driver does not support these features? If
>> >> >>> not can
>> >> >> you clarify the issue so I can raise with the AP team.
>> >> >>>
>> >> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the AP
>> >> >> requires NSS to be no less than 4, that is why EHT connection was disabled.
>> >> >
>> >> > Which field is requiring NSS of 4, I'm only seeing a maximum of 4, the
>> >> Qualcomm windows driver will connect to the same AP, we had assumed that
>> >> that ath12k would do the same.
>> >> Basic EHT-MCS And Nss Set: 0x44444444
>> >
>> > My understanding of the spec is that there are maximum numbers of
>> > streams though, are you saying the AP has to advertise 0x22222222
>> > which would then prevent a 4x4 client (say an extender) from
>> > connecting with 4 streams? I note that the Qualcomm windows driver for
>> > Hamilton works with the AP and an Intel BE200 also works both of which
>> > will be in at most 2x2
>>
>> Did you test Intel BE200 with the Windows driver? Johannes mentioned
>> that ieee80211_verify_sta_eht_mcs_support() in mac80211 checks this so I
>> would assume that iwlwifi also behaves like ath12k.
>
> Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
> In other case station  < 4nss will drop to HE only.

Thanks. And Johannes pointed out that you had even discussed about this
before:

https://lore.kernel.org/linux-wireless/CAFED-jk8pJheJEViESnE54f-K+JgRMiWoiCSa0GBt=RKaCn7sw@mail.gmail.com/

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
https://docs.kernel.org/process/submitting-patches.html

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: wcn7850 issues
  2024-09-03 10:09                                 ` Kalle Valo
@ 2024-09-03 21:15                                   ` david Atkins
  2024-09-04  5:08                                     ` Janusz Dziedzic
  0 siblings, 1 reply; 8+ messages in thread
From: david Atkins @ 2024-09-03 21:15 UTC (permalink / raw)
  To: Kalle Valo, Janusz Dziedzic
  Cc: Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless@vger.kernel.org

> > wt., 3 wrz 2024 o 09:47 Kalle Valo <kvalo@kernel.org> napisał(a):
> >>
> >> + linux-wireless
> >>
> >> david Atkins <david@3adesign.co.uk> writes:
> >>
> >> > ...
> >> >> >>>         Ext Tag: EHT Operation (802.11be D3.0)
> >> >> >>>             Ext Tag length: 8 (Tag len: 9)
> >> >> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
> >> >> >>>             EHT Operation Parameters: 0x01, EHT Operation
> >> >> >>> Information
> >> >> Present
> >> >> >>>                 .... ...1 = EHT Operation Information Present: True
> >> >> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
> >> >> >>>                 .... .0.. = EHT Default PE Duration: False
> >> >> >>>                 .... 0... = Group Addressed BU Indication Limit: False
> >> >> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
> >> >> >>>                 00.. .... = Reserved: 0x0
> >> >> >>>             Basic EHT-MCS And Nss Set: 0x44444444
> >> >> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS bandwidth
> >> >> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth (2)
> >> >> >>>                 0000 0... = Reserved: 0x00
> >> >> >>>
> >> >> >>> Are you saying the ath12k driver does not support these
> >> >> >>> features? If not can
> >> >> >> you clarify the issue so I can raise with the AP team.
> >> >> >>>
> >> >> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the AP
> >> >> >> requires NSS to be no less than 4, that is why EHT connection was
> disabled.
> >> >> >
> >> >> > Which field is requiring NSS of 4, I'm only seeing a maximum of
> >> >> > 4, the
> >> >> Qualcomm windows driver will connect to the same AP, we had
> >> >> assumed that that ath12k would do the same.
> >> >> Basic EHT-MCS And Nss Set: 0x44444444
> >> >
> >> > My understanding of the spec is that there are maximum numbers of
> >> > streams though, are you saying the AP has to advertise 0x22222222
> >> > which would then prevent a 4x4 client (say an extender) from
> >> > connecting with 4 streams? I note that the Qualcomm windows driver
> >> > for Hamilton works with the AP and an Intel BE200 also works both
> >> > of which will be in at most 2x2
> >>
> >> Did you test Intel BE200 with the Windows driver? Johannes mentioned
> >> that ieee80211_verify_sta_eht_mcs_support() in mac80211 checks this
> >> so I would assume that iwlwifi also behaves like ath12k.
> >
> > Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
> > In other case station  < 4nss will drop to HE only.
> 
> Thanks. And Johannes pointed out that you had even discussed about this
> before:
> 
> https://lore.kernel.org/linux-wireless/CAFED-jk8pJheJEViESnE54f-
> K+JgRMiWoiCSa0GBt=RKaCn7sw@mail.gmail.com/
> 

So this 

Basic EHT-MCS And Nss Set: 0x44444444

Should be 0x11111111 ? and it defines the minimum number of streams needed to connect?

This the defines the max streams ?

            Supported EHT-MCS and NSS Set
                EHT-MCS Map (BW <= 80MHz): 0x444444
                    .... .... .... .... .... 0100 = Rx Max Nss That Supports EHT-MCS 0-9: 4
                    .... .... .... .... 0100 .... = Tx Max Nss That Supports EHT-MCS 0-9: 4
                    .... .... .... 0100 .... .... = Rx Max Nss That Supports EHT-MCS 10-11: 4
                    .... .... 0100 .... .... .... = Tx Max Nss That Supports EHT-MCS 10-11: 4
                    .... 0100 .... .... .... .... = Rx Max Nss That Supports EHT-MCS 12-13: 4
                    0100 .... .... .... .... .... = Tx Max Nss That Supports EHT-MCS 12-13: 4


david

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: wcn7850 issues
  2024-09-03 21:15                                   ` david Atkins
@ 2024-09-04  5:08                                     ` Janusz Dziedzic
  2024-09-04  6:04                                       ` david Atkins
  0 siblings, 1 reply; 8+ messages in thread
From: Janusz Dziedzic @ 2024-09-04  5:08 UTC (permalink / raw)
  To: david Atkins
  Cc: Kalle Valo, Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless@vger.kernel.org

wt., 3 wrz 2024 o 23:15 david Atkins <david@3adesign.co.uk> napisał(a):
>
> > > wt., 3 wrz 2024 o 09:47 Kalle Valo <kvalo@kernel.org> napisał(a):
> > >>
> > >> + linux-wireless
> > >>
> > >> david Atkins <david@3adesign.co.uk> writes:
> > >>
> > >> > ...
> > >> >> >>>         Ext Tag: EHT Operation (802.11be D3.0)
> > >> >> >>>             Ext Tag length: 8 (Tag len: 9)
> > >> >> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
> > >> >> >>>             EHT Operation Parameters: 0x01, EHT Operation
> > >> >> >>> Information
> > >> >> Present
> > >> >> >>>                 .... ...1 = EHT Operation Information Present: True
> > >> >> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
> > >> >> >>>                 .... .0.. = EHT Default PE Duration: False
> > >> >> >>>                 .... 0... = Group Addressed BU Indication Limit: False
> > >> >> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
> > >> >> >>>                 00.. .... = Reserved: 0x0
> > >> >> >>>             Basic EHT-MCS And Nss Set: 0x44444444
> > >> >> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS bandwidth
> > >> >> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth (2)
> > >> >> >>>                 0000 0... = Reserved: 0x00
> > >> >> >>>
> > >> >> >>> Are you saying the ath12k driver does not support these
> > >> >> >>> features? If not can
> > >> >> >> you clarify the issue so I can raise with the AP team.
> > >> >> >>>
> > >> >> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the AP
> > >> >> >> requires NSS to be no less than 4, that is why EHT connection was
> > disabled.
> > >> >> >
> > >> >> > Which field is requiring NSS of 4, I'm only seeing a maximum of
> > >> >> > 4, the
> > >> >> Qualcomm windows driver will connect to the same AP, we had
> > >> >> assumed that that ath12k would do the same.
> > >> >> Basic EHT-MCS And Nss Set: 0x44444444
> > >> >
> > >> > My understanding of the spec is that there are maximum numbers of
> > >> > streams though, are you saying the AP has to advertise 0x22222222
> > >> > which would then prevent a 4x4 client (say an extender) from
> > >> > connecting with 4 streams? I note that the Qualcomm windows driver
> > >> > for Hamilton works with the AP and an Intel BE200 also works both
> > >> > of which will be in at most 2x2
> > >>
> > >> Did you test Intel BE200 with the Windows driver? Johannes mentioned
> > >> that ieee80211_verify_sta_eht_mcs_support() in mac80211 checks this
> > >> so I would assume that iwlwifi also behaves like ath12k.
> > >
> > > Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
> > > In other case station  < 4nss will drop to HE only.
> >
> > Thanks. And Johannes pointed out that you had even discussed about this
> > before:
> >
> > https://lore.kernel.org/linux-wireless/CAFED-jk8pJheJEViESnE54f-
> > K+JgRMiWoiCSa0GBt=RKaCn7sw@mail.gmail.com/
> >
>
> So this
>
> Basic EHT-MCS And Nss Set: 0x44444444
>
> Should be 0x11111111 ? and it defines the minimum number of streams needed to connect?
>
> This the defines the max streams ?
>
>             Supported EHT-MCS and NSS Set
>                 EHT-MCS Map (BW <= 80MHz): 0x444444
>                     .... .... .... .... .... 0100 = Rx Max Nss That Supports EHT-MCS 0-9: 4
>                     .... .... .... .... 0100 .... = Tx Max Nss That Supports EHT-MCS 0-9: 4
>                     .... .... .... 0100 .... .... = Rx Max Nss That Supports EHT-MCS 10-11: 4
>                     .... .... 0100 .... .... .... = Tx Max Nss That Supports EHT-MCS 10-11: 4
>                     .... 0100 .... .... .... .... = Rx Max Nss That Supports EHT-MCS 12-13: 4
>                     0100 .... .... .... .... .... = Tx Max Nss That Supports EHT-MCS 12-13: 4
>
You mix different things:

Supported EHT-MCS and NSS set  vs Basic EHT-MCS And Nss Set

^ permalink raw reply	[flat|nested] 8+ messages in thread

* RE: wcn7850 issues
  2024-09-04  5:08                                     ` Janusz Dziedzic
@ 2024-09-04  6:04                                       ` david Atkins
  2024-09-04  7:08                                         ` Janusz Dziedzic
  0 siblings, 1 reply; 8+ messages in thread
From: david Atkins @ 2024-09-04  6:04 UTC (permalink / raw)
  To: Janusz Dziedzic
  Cc: Kalle Valo, Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless@vger.kernel.org

> > > >> > ...
> > > >> >> >>>         Ext Tag: EHT Operation (802.11be D3.0)
> > > >> >> >>>             Ext Tag length: 8 (Tag len: 9)
> > > >> >> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
> > > >> >> >>>             EHT Operation Parameters: 0x01, EHT Operation
> > > >> >> >>> Information
> > > >> >> Present
> > > >> >> >>>                 .... ...1 = EHT Operation Information Present: True
> > > >> >> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
> > > >> >> >>>                 .... .0.. = EHT Default PE Duration: False
> > > >> >> >>>                 .... 0... = Group Addressed BU Indication Limit: False
> > > >> >> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
> > > >> >> >>>                 00.. .... = Reserved: 0x0
> > > >> >> >>>             Basic EHT-MCS And Nss Set: 0x44444444
> > > >> >> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS
> bandwidth
> > > >> >> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth
> (2)
> > > >> >> >>>                 0000 0... = Reserved: 0x00
> > > >> >> >>>
> > > >> >> >>> Are you saying the ath12k driver does not support these
> > > >> >> >>> features? If not can
> > > >> >> >> you clarify the issue so I can raise with the AP team.
> > > >> >> >>>
> > > >> >> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the
> > > >> >> >> AP requires NSS to be no less than 4, that is why EHT
> > > >> >> >> connection was
> > > disabled.
> > > >> >> >
> > > >> >> > Which field is requiring NSS of 4, I'm only seeing a maximum
> > > >> >> > of 4, the
> > > >> >> Qualcomm windows driver will connect to the same AP, we had
> > > >> >> assumed that that ath12k would do the same.
> > > >> >> Basic EHT-MCS And Nss Set: 0x44444444
> > > >> >
> > > >> > My understanding of the spec is that there are maximum numbers
> > > >> > of streams though, are you saying the AP has to advertise
> > > >> > 0x22222222 which would then prevent a 4x4 client (say an
> > > >> > extender) from connecting with 4 streams? I note that the
> > > >> > Qualcomm windows driver for Hamilton works with the AP and an
> > > >> > Intel BE200 also works both of which will be in at most 2x2
> > > >>
> > > >> Did you test Intel BE200 with the Windows driver? Johannes
> > > >> mentioned that ieee80211_verify_sta_eht_mcs_support() in mac80211
> > > >> checks this so I would assume that iwlwifi also behaves like ath12k.
> > > >
> > > > Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
> > > > In other case station  < 4nss will drop to HE only.
> > >
> > > Thanks. And Johannes pointed out that you had even discussed about
> > > this
> > > before:
> > >
> > > https://lore.kernel.org/linux-wireless/CAFED-jk8pJheJEViESnE54f-
> > > K+JgRMiWoiCSa0GBt=RKaCn7sw@mail.gmail.com/
> > >
> >
> > So this
> >
> > Basic EHT-MCS And Nss Set: 0x44444444
> >
> > Should be 0x11111111 ? and it defines the minimum number of streams
> needed to connect?
> >
> > This the defines the max streams ?
> >
> >             Supported EHT-MCS and NSS Set
> >                 EHT-MCS Map (BW <= 80MHz): 0x444444
> >                     .... .... .... .... .... 0100 = Rx Max Nss That Supports EHT-MCS 0-9:
> 4
> >                     .... .... .... .... 0100 .... = Tx Max Nss That Supports EHT-MCS 0-9: 4
> >                     .... .... .... 0100 .... .... = Rx Max Nss That Supports EHT-MCS 10-
> 11: 4
> >                     .... .... 0100 .... .... .... = Tx Max Nss That Supports EHT-MCS 10-
> 11: 4
> >                     .... 0100 .... .... .... .... = Rx Max Nss That Supports EHT-MCS 12-
> 13: 4
> >                     0100 .... .... .... .... .... = Tx Max Nss That
> > Supports EHT-MCS 12-13: 4
> >
> You mix different things:
> 
> Supported EHT-MCS and NSS set  vs Basic EHT-MCS And Nss Set

So the basic set is the minimum?

David


^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: wcn7850 issues
  2024-09-04  6:04                                       ` david Atkins
@ 2024-09-04  7:08                                         ` Janusz Dziedzic
  0 siblings, 0 replies; 8+ messages in thread
From: Janusz Dziedzic @ 2024-09-04  7:08 UTC (permalink / raw)
  To: david Atkins
  Cc: Kalle Valo, Baochen Qiang, ath12k@lists.infradead.org,
	linux-wireless@vger.kernel.org

śr., 4 wrz 2024 o 08:04 david Atkins <david@3adesign.co.uk> napisał(a):
>
> > > > >> > ...
> > > > >> >> >>>         Ext Tag: EHT Operation (802.11be D3.0)
> > > > >> >> >>>             Ext Tag length: 8 (Tag len: 9)
> > > > >> >> >>>             Ext Tag Number: EHT Operation (802.11be D3.0) (106)
> > > > >> >> >>>             EHT Operation Parameters: 0x01, EHT Operation
> > > > >> >> >>> Information
> > > > >> >> Present
> > > > >> >> >>>                 .... ...1 = EHT Operation Information Present: True
> > > > >> >> >>>                 .... ..0. = Disabled Subchannel Bitmap Present: False
> > > > >> >> >>>                 .... .0.. = EHT Default PE Duration: False
> > > > >> >> >>>                 .... 0... = Group Addressed BU Indication Limit: False
> > > > >> >> >>>                 ..00 .... = Group Addressed BU Indication Exponent: 0
> > > > >> >> >>>                 00.. .... = Reserved: 0x0
> > > > >> >> >>>             Basic EHT-MCS And Nss Set: 0x44444444
> > > > >> >> >>>             Control: 0x02, Channel Width: 80 MHz EHT BSS
> > bandwidth
> > > > >> >> >>>                 .... .010 = Channel Width: 80 MHz EHT BSS bandwidth
> > (2)
> > > > >> >> >>>                 0000 0... = Reserved: 0x00
> > > > >> >> >>>
> > > > >> >> >>> Are you saying the ath12k driver does not support these
> > > > >> >> >>> features? If not can
> > > > >> >> >> you clarify the issue so I can raise with the AP team.
> > > > >> >> >>>
> > > > >> >> >> ath12k/WCN7850 supports EHT, but with NSS only 2. Here the
> > > > >> >> >> AP requires NSS to be no less than 4, that is why EHT
> > > > >> >> >> connection was
> > > > disabled.
> > > > >> >> >
> > > > >> >> > Which field is requiring NSS of 4, I'm only seeing a maximum
> > > > >> >> > of 4, the
> > > > >> >> Qualcomm windows driver will connect to the same AP, we had
> > > > >> >> assumed that that ath12k would do the same.
> > > > >> >> Basic EHT-MCS And Nss Set: 0x44444444
> > > > >> >
> > > > >> > My understanding of the spec is that there are maximum numbers
> > > > >> > of streams though, are you saying the AP has to advertise
> > > > >> > 0x22222222 which would then prevent a 4x4 client (say an
> > > > >> > extender) from connecting with 4 streams? I note that the
> > > > >> > Qualcomm windows driver for Hamilton works with the AP and an
> > > > >> > Intel BE200 also works both of which will be in at most 2x2
> > > > >>
> > > > >> Did you test Intel BE200 with the Windows driver? Johannes
> > > > >> mentioned that ieee80211_verify_sta_eht_mcs_support() in mac80211
> > > > >> checks this so I would assume that iwlwifi also behaves like ath12k.
> > > > >
> > > > > Yes, this is AP issue - hostapd fix required - advertise 0x11111 ...
> > > > > In other case station  < 4nss will drop to HE only.
> > > >
> > > > Thanks. And Johannes pointed out that you had even discussed about
> > > > this
> > > > before:
> > > >
> > > > https://lore.kernel.org/linux-wireless/CAFED-jk8pJheJEViESnE54f-
> > > > K+JgRMiWoiCSa0GBt=RKaCn7sw@mail.gmail.com/
> > > >
> > >
> > > So this
> > >
> > > Basic EHT-MCS And Nss Set: 0x44444444
> > >
> > > Should be 0x11111111 ? and it defines the minimum number of streams
> > needed to connect?
> > >
> > > This the defines the max streams ?
> > >
> > >             Supported EHT-MCS and NSS Set
> > >                 EHT-MCS Map (BW <= 80MHz): 0x444444
> > >                     .... .... .... .... .... 0100 = Rx Max Nss That Supports EHT-MCS 0-9:
> > 4
> > >                     .... .... .... .... 0100 .... = Tx Max Nss That Supports EHT-MCS 0-9: 4
> > >                     .... .... .... 0100 .... .... = Rx Max Nss That Supports EHT-MCS 10-
> > 11: 4
> > >                     .... .... 0100 .... .... .... = Tx Max Nss That Supports EHT-MCS 10-
> > 11: 4
> > >                     .... 0100 .... .... .... .... = Rx Max Nss That Supports EHT-MCS 12-
> > 13: 4
> > >                     0100 .... .... .... .... .... = Tx Max Nss That
> > > Supports EHT-MCS 12-13: 4
> > >
> > You mix different things:
> >
> > Supported EHT-MCS and NSS set  vs Basic EHT-MCS And Nss Set
>
> So the basic set is the minimum?
>

linux mac80211 check it as minimum - if not pass disable client EHT

OS hostapd set is as 0x00000011 but there is some TODO - so maybe
someone else should describe it more :)
https://w1.fi/cgit/hostap/tree/src/ap/ieee802_11_eht.c#n235

So, eg. OpenWrt/main EHT AP on mt7996e use 0x00000011, and Intel
BE200/WCN7850 connect using EHT

BR
Janusz

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2024-09-04  7:09 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <LO0P123MB4057D6C2F6FEFF335B30EE7CD6BF2@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found] ` <LO0P123MB4057122D4C7D07C7114F5ABED6BF2@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]   ` <be53813c-3edc-4734-b59d-83f43f14ea91@quicinc.com>
     [not found]     ` <LO0P123MB4057C3085F445434F5E87B3AD6872@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]       ` <26bb8ec7-7170-4a09-ada3-c7c753c16e87@quicinc.com>
     [not found]         ` <LO0P123MB40573F46A6D63145363C6B13D6812@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]           ` <cfe8e314-a28b-4ea3-85b2-9f5b4ac2db09@quicinc.com>
     [not found]             ` <LO0P123MB405769E063E48B0F7AE18C5FD68C2@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]               ` <LO0P123MB4057E823BDB7B9ECCCD75840D6972@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]                 ` <a6c609fc-150b-4779-b3f6-dddbd6ce93dc@quicinc.com>
     [not found]                   ` <LO0P123MB40578A6CEC43AEFE301F9ED8D6912@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]                     ` <86bc1623-8845-43fa-9aad-a8a6066b1448@quicinc.com>
     [not found]                       ` <LO0P123MB4057266AFF389FA69FDC84B8D6922@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
     [not found]                         ` <fb455a66-b29b-4eb0-984c-254f9a1c5626@quicinc.com>
     [not found]                           ` <LO0P123MB40578B26075CD4C9C66D144BD6932@LO0P123MB4057.GBRP123.PROD.OUTLOOK.COM>
2024-09-03  7:47                             ` wcn7850 issues Kalle Valo
2024-09-03  9:57                               ` Janusz Dziedzic
2024-09-03 10:07                                 ` Johannes Berg
2024-09-03 10:09                                 ` Kalle Valo
2024-09-03 21:15                                   ` david Atkins
2024-09-04  5:08                                     ` Janusz Dziedzic
2024-09-04  6:04                                       ` david Atkins
2024-09-04  7:08                                         ` Janusz Dziedzic

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).