linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP
@ 2024-07-18  7:06 Ping-Ke Shih
  2024-07-18  7:06 ` [PATCH 2/2] wifi: rtw89: " Ping-Ke Shih
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Ping-Ke Shih @ 2024-07-18  7:06 UTC (permalink / raw)
  To: linux-wireless; +Cc: kevin_yang

From: Zong-Zhe Yang <kevin_yang@realtek.com>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw88/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw88/Kconfig b/drivers/net/wireless/realtek/rtw88/Kconfig
index 22838ede03cd..02b0d698413b 100644
--- a/drivers/net/wireless/realtek/rtw88/Kconfig
+++ b/drivers/net/wireless/realtek/rtw88/Kconfig
@@ -12,6 +12,7 @@ if RTW88
 
 config RTW88_CORE
 	tristate
+	select WANT_DEV_COREDUMP
 
 config RTW88_PCI
 	tristate
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] wifi: rtw89: select WANT_DEV_COREDUMP
  2024-07-18  7:06 [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP Ping-Ke Shih
@ 2024-07-18  7:06 ` Ping-Ke Shih
  2024-07-30 13:08 ` [PATCH 1/2] wifi: rtw88: " Kalle Valo
  2024-07-31  5:46 ` Ping-Ke Shih
  2 siblings, 0 replies; 6+ messages in thread
From: Ping-Ke Shih @ 2024-07-18  7:06 UTC (permalink / raw)
  To: linux-wireless; +Cc: kevin_yang

From: Zong-Zhe Yang <kevin_yang@realtek.com>

We have invoked device coredump when fw crash.
Should select WANT_DEV_COREDUMP by ourselves.

Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
---
 drivers/net/wireless/realtek/rtw89/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/realtek/rtw89/Kconfig b/drivers/net/wireless/realtek/rtw89/Kconfig
index 3c9f864805b1..6278fd74e98e 100644
--- a/drivers/net/wireless/realtek/rtw89/Kconfig
+++ b/drivers/net/wireless/realtek/rtw89/Kconfig
@@ -12,6 +12,7 @@ if RTW89
 
 config RTW89_CORE
 	tristate
+	select WANT_DEV_COREDUMP
 
 config RTW89_PCI
 	tristate
-- 
2.25.1


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP
  2024-07-18  7:06 [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP Ping-Ke Shih
  2024-07-18  7:06 ` [PATCH 2/2] wifi: rtw89: " Ping-Ke Shih
@ 2024-07-30 13:08 ` Kalle Valo
  2024-07-31  0:38   ` Ping-Ke Shih
  2024-07-31  5:46 ` Ping-Ke Shih
  2 siblings, 1 reply; 6+ messages in thread
From: Kalle Valo @ 2024-07-30 13:08 UTC (permalink / raw)
  To: Ping-Ke Shih; +Cc: linux-wireless, kevin_yang

Ping-Ke Shih <pkshih@realtek.com> writes:

> From: Zong-Zhe Yang <kevin_yang@realtek.com>
>
> We have invoked device coredump when fw crash.
> Should select WANT_DEV_COREDUMP by ourselves.
>
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

Should these two go to wireless tree? If yes, please assign the patches
to me on patchwork. But rtw tree is fine for me as well, your call.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread

* RE: [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP
  2024-07-30 13:08 ` [PATCH 1/2] wifi: rtw88: " Kalle Valo
@ 2024-07-31  0:38   ` Ping-Ke Shih
  2024-07-31  8:39     ` Kalle Valo
  0 siblings, 1 reply; 6+ messages in thread
From: Ping-Ke Shih @ 2024-07-31  0:38 UTC (permalink / raw)
  To: Kalle Valo; +Cc: linux-wireless@vger.kernel.org, Zong-Zhe Yang

Kalle Valo <kvalo@kernel.org> wrote:
> Ping-Ke Shih <pkshih@realtek.com> writes:
> 
> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
> >
> > We have invoked device coredump when fw crash.
> > Should select WANT_DEV_COREDUMP by ourselves.
> >
> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
> 
> Should these two go to wireless tree? If yes, please assign the patches
> to me on patchwork. But rtw tree is fine for me as well, your call.

For most distro, other drivers select this flag, so not urgent to have these
two patches. Then they will go via rtw tree. Thanks. 



^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP
  2024-07-18  7:06 [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP Ping-Ke Shih
  2024-07-18  7:06 ` [PATCH 2/2] wifi: rtw89: " Ping-Ke Shih
  2024-07-30 13:08 ` [PATCH 1/2] wifi: rtw88: " Kalle Valo
@ 2024-07-31  5:46 ` Ping-Ke Shih
  2 siblings, 0 replies; 6+ messages in thread
From: Ping-Ke Shih @ 2024-07-31  5:46 UTC (permalink / raw)
  To: Ping-Ke Shih, linux-wireless; +Cc: kevin_yang

Ping-Ke Shih <pkshih@realtek.com> wrote:

> From: Zong-Zhe Yang <kevin_yang@realtek.com>
> 
> We have invoked device coredump when fw crash.
> Should select WANT_DEV_COREDUMP by ourselves.
> 
> Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
> Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>

2 patch(es) applied to rtw-next branch of rtw.git, thanks.

7e989b0c1e33 wifi: rtw88: select WANT_DEV_COREDUMP
d523dc49d13e wifi: rtw89: select WANT_DEV_COREDUMP

---
https://github.com/pkshih/rtw.git


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP
  2024-07-31  0:38   ` Ping-Ke Shih
@ 2024-07-31  8:39     ` Kalle Valo
  0 siblings, 0 replies; 6+ messages in thread
From: Kalle Valo @ 2024-07-31  8:39 UTC (permalink / raw)
  To: Ping-Ke Shih; +Cc: linux-wireless@vger.kernel.org, Zong-Zhe Yang

Ping-Ke Shih <pkshih@realtek.com> writes:

> Kalle Valo <kvalo@kernel.org> wrote:
>> Ping-Ke Shih <pkshih@realtek.com> writes:
>> 
>> > From: Zong-Zhe Yang <kevin_yang@realtek.com>
>> >
>> > We have invoked device coredump when fw crash.
>> > Should select WANT_DEV_COREDUMP by ourselves.
>> >
>> > Signed-off-by: Zong-Zhe Yang <kevin_yang@realtek.com>
>> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
>> 
>> Should these two go to wireless tree? If yes, please assign the patches
>> to me on patchwork. But rtw tree is fine for me as well, your call.
>
> For most distro, other drivers select this flag, so not urgent to have these
> two patches. Then they will go via rtw tree. Thanks. 

Makes sense, thanks.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2024-07-31  8:39 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-07-18  7:06 [PATCH 1/2] wifi: rtw88: select WANT_DEV_COREDUMP Ping-Ke Shih
2024-07-18  7:06 ` [PATCH 2/2] wifi: rtw89: " Ping-Ke Shih
2024-07-30 13:08 ` [PATCH 1/2] wifi: rtw88: " Kalle Valo
2024-07-31  0:38   ` Ping-Ke Shih
2024-07-31  8:39     ` Kalle Valo
2024-07-31  5:46 ` Ping-Ke Shih

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).