Re: [PATCH net-next] wifi: ti/wlcore: Convert to platform remove callback returning void

[Kalle Valo <kvalo@kernel.org>]

Uwe Kleine-König <u.kleine-koenig@pengutronix.de> writes:

> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code.  However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> wlcore_remove() returned zero unconditionally. With that converted to
> return void instead, the wl12xx and wl18xx driver can be converted to
> .remove_new trivially.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  drivers/net/wireless/ti/wl12xx/main.c   | 6 +++---
>  drivers/net/wireless/ti/wl18xx/main.c   | 2 +-
>  drivers/net/wireless/ti/wlcore/main.c   | 6 ++----
>  drivers/net/wireless/ti/wlcore/wlcore.h | 2 +-
>  4 files changed, 7 insertions(+), 9 deletions(-)

wireless patches go to wireless-next, not net-next. But no need to
resend because of this.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches