From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30E4FEB64DD for ; Thu, 20 Jul 2023 06:55:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231313AbjGTGzp (ORCPT ); Thu, 20 Jul 2023 02:55:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34812 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229731AbjGTGzo (ORCPT ); Thu, 20 Jul 2023 02:55:44 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 44A5B1711 for ; Wed, 19 Jul 2023 23:55:43 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF268618E1 for ; Thu, 20 Jul 2023 06:55:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 60A44C433C7; Thu, 20 Jul 2023 06:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1689836141; bh=Y7xhXA8cRIFiZM+O3xe+B7rVetwM5gUm3s6BbKfNQNU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=JaH4OPDH0zd4O03ZXzlucCErb/V4qBZRqniOYIJsYqYjY7lFBD66UQtFRdRObtFm+ Ft++6VErQBRhnwEWjaJmM88dfRy6GhZP/Qwl1I5ONdWwTSLyPgxhnyRsvQSdodKFX4 BpMvbv7OMHmd94RnguAjb0IFPc4aWovnpg0RWTp/fEmRPT3QSRNgbF44VvVybpvOVi 7jtl9hxhkrdLcyBcQ//PJpqmvGOXOCD9gXS6tqrNQAeyOYVqsp0+X+1ogPqZjs/063 MaV/Lp59Y5hwo1a9q6xjMpMdoqjV2yS/eywQf1SjEe3UvSBdBIXftR0PL4W7tieWOA 9uFqmB5NlWS1A== From: Kalle Valo To: Jakub Kicinski Cc: Pink Perfect , amitkarwar@gmail.com, ganapathi017@gmail.com, sharvari.harisangam@nxp.com, huxinming820@gmail.com, linux-wireless@vger.kernel.org Subject: Re: [PATCH v3] wifi: mwifiex: Fix OOB and integer underflow when rx packets References: <20230713023731.2518507-1-pinkperfect2021@gmail.com> <20230713105644.49444826@kernel.org> Date: Thu, 20 Jul 2023 09:55:38 +0300 In-Reply-To: <20230713105644.49444826@kernel.org> (Jakub Kicinski's message of "Thu, 13 Jul 2023 10:56:44 -0700") Message-ID: <87sf9j3wd1.fsf@kernel.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Jakub Kicinski writes: > On Thu, 13 Jul 2023 10:44:56 +0800 Pink Perfect wrote: >> Sorry, forgot to change the signoff name, after you review this patch I = can >> submit a new one > > Do you mean change to "Pink Perfect", is that the name you'd sign > legal documents with? > >> On Thu, Jul 13, 2023 at 10:37=E2=80=AFAM pinkperfect >> wrote: >>=20 >> > Make sure mwifiex_process_mgmt_packet and its callers >> > mwifiex_process_sta_rx_packet and mwifiex_process_uap_rx_packet >> > not out-of-bounds access the skb->data buffer. >> > >> > Fixes: 2dbaf751b1de ("mwifiex: report received management frames to >> > cfg80211") >> > >> > Signed-off-by: pinkperfect > > No empty lines between tags, please. > > You mentioned reporting the problem to chromeos, since mwifiex > "maintainters" seem to be AWoL, would someone from their team > possibly be willing to venture a review tag for the patch? We have four maintainers for mwifiex and total silence: MARVELL MWIFIEX WIRELESS DRIVER M: Amitkumar Karwar M: Ganapathi Bhat M: Sharvari Harisangam M: Xinming Hu L: linux-wireless@vger.kernel.org S: Maintained F: drivers/net/wireless/marvell/mwifiex/ I'm very close of marking this driver as orphan unless anyone steps up. This is not how to maintain a driver. --=20 https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatc= hes