linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@kernel.org>
To: Wenli Looi <wlooi@ucalgary.ca>
Cc: "Toke Høiland-Jørgensen" <toke@toke.dk>,
	linux-wireless@vger.kernel.org,
	"Jeff Johnson" <quic_jjohnson@quicinc.com>
Subject: Re: [PATCH] ath9k: remove most hidden macro dependencies on ah
Date: Tue, 20 Dec 2022 07:21:55 +0200	[thread overview]
Message-ID: <87sfhak5u4.fsf@kernel.org> (raw)
In-Reply-To: <df8c4daf-7bec-a877-285a-4f690fdc87c@ucalgary.ca> (Wenli Looi's message of "Mon, 19 Dec 2022 11:12:59 -0800 (PST)")

Wenli Looi <wlooi@ucalgary.ca> writes:

> One thing I just noticed is that when compiling with CONFIG_ATH_DEBUG, 
> there is one slight difference in the binary because of this change:
>
> -			"Timeout while waiting for nf to load: AR_PHY_AGC_CONTROL=0x%x\n",
> -			REG_READ(ah, AR_PHY_AGC_CONTROL));
> +			"Timeout while waiting for nf to load: AR_PHY_AGC_CONTROL(ah)=0x%x\n",
> +			REG_READ(ah, AR_PHY_AGC_CONTROL(ah)));

Good catch, I can remove the "(ah)" from the string in the pending
branch.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2022-12-20  5:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-06  9:02 [PATCH] ath9k: remove most hidden macro dependencies on ah Wenli Looi
2022-12-15 15:12 ` Toke Høiland-Jørgensen
2022-12-19 19:12   ` Wenli Looi
2022-12-20  5:21     ` Kalle Valo [this message]
2022-12-22 17:14 ` Kalle Valo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfhak5u4.fsf@kernel.org \
    --to=kvalo@kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=quic_jjohnson@quicinc.com \
    --cc=toke@toke.dk \
    --cc=wlooi@ucalgary.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).