From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF77AC4332F for ; Wed, 30 Nov 2022 05:15:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233369AbiK3FPN (ORCPT ); Wed, 30 Nov 2022 00:15:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58354 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233497AbiK3FOd (ORCPT ); Wed, 30 Nov 2022 00:14:33 -0500 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8603A1658B; Tue, 29 Nov 2022 21:14:12 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 247F061A0D; Wed, 30 Nov 2022 05:14:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EC373C433D6; Wed, 30 Nov 2022 05:14:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1669785251; bh=CqrmiuOOxenDGqbbJzSkLOlZlAOT8xZfVDi8NlAoucg=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=X5LsRBBmSdMxilT7u1kEOnYe1lcKIhr0qRADdbDRXYrFsTm6sVEujTgKxCUkNV3rQ +qWzWRJ1xa7zhDoS4Ce94E10R+Zry4YJOWhaWl0snQqpJH0pvDRX0dGRV2SxKvX0W1 yqA2ZqCaHXV96Wv1cJU/IRHBQCJ7HsykzNNBaHN86cAvwq8/OkiJG908gRR4J5f0/g TbaX/DWOeTEz1oOg8Tx5qrgv2wWSQF0sQshbq5UFeizM21Mro4wD5smfET6tLOFnT2 mHQTtOusPTzAzsuU8OjlXoeJ9XvH1FP8dB/ZLlkjXS5NSyASvHjago/qe2MjgUi5z7 FQIEBOEoV7Kgw== From: Kalle Valo To: Nathan Chancellor Cc: Youghandhar Chintala , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, quic_mpubbise@quicinc.com, rameshn@qti.qualcomm.com Subject: Re: [PATCH v4] wifi: ath10k: Store WLAN firmware version in SMEM image table In-Reply-To: (Nathan Chancellor's message of "Tue, 29 Nov 2022 09:01:13 -0700") References: <20221117180534.2267-1-quic_youghand@quicinc.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Wed, 30 Nov 2022 07:14:05 +0200 Message-ID: <87sfi13tya.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Nathan Chancellor writes: > On Thu, Nov 17, 2022 at 11:35:34PM +0530, Youghandhar Chintala wrote: > >> In a SoC based solution, it would be useful to know the versions of the >> various binary firmware blobs the system is running on. On a QCOM based >> SoC, this info can be obtained from socinfo debugfs infrastructure. For >> this to work, respective subsystem drivers have to export the firmware >> version information to an SMEM based version information table. >> >> Having firmware version information at one place will help quickly >> figure out the firmware versions of various subsystems on the device >> instead of going through builds/logs in an event of a system crash. >> >> Fill WLAN firmware version information in SMEM version table to be >> printed as part of socinfo debugfs infrastructure on a Qualcomm based >> SoC. >> >> This change is applicable only for SNOC/QMI based targets. >> >> Example: >> cat /sys/kernel/debug/qcom_socinfo/cnss/name >> QC_IMAGE_VERSION_STRING=WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1 >> >> Tested-on: WCN3990 hw1.0 SNOC WLAN.HL.3.2.2.c10-00754-QCAHLSWMTPL-1 >> >> Signed-off-by: Youghandhar Chintala >> --- >> Changes from v3: >> - Changed patch title >> - Changed naming conventions >> - Removed MAX_BUILD_ID_LEN usuage >> - Added condition to call API >> - Changed depends on QCOM_SMEM to select QCOM_SMEM > > You cannot blindly select user configurable symbols that have > dependencies, otherwise you end up with Kconfig warnings. I see the > following warning in -next when CONFIG_HWSPINLOCK is disabled: > > WARNING: unmet direct dependencies detected for QCOM_SMEM > Depends on [n]: (ARCH_QCOM [=y] || COMPILE_TEST [=n]) && HWSPINLOCK [=n] > Selected by [m]: > - ATH10K_SNOC [=m] && NETDEVICES [=y] && WLAN [=y] && WLAN_VENDOR_ATH [=y] && ATH10K [=m] && (ARCH_QCOM [=y] || COMPILE_TEST [=n]) > > That should likely be changed back to 'depends on'. The reason the other > QCOM symbols are selected is because they are not user-selectable, so > they have to be selected by the configurations that need them. Thanks, I didn't realise this. I'll send a patch changing it to 'depends on'. -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches