From: Kalle Valo <kvalo@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pkshih@realtek.com,
ath11k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next 1/2] codel: remove unnecessary sock.h include
Date: Wed, 22 Dec 2021 07:56:05 +0200 [thread overview]
Message-ID: <87sful2ney.fsf@kernel.org> (raw)
In-Reply-To: <20211221193941.3805147-1-kuba@kernel.org> (Jakub Kicinski's message of "Tue, 21 Dec 2021 11:39:40 -0800")
Jakub Kicinski <kuba@kernel.org> writes:
> Since sock.h is modified relatively often (60 times in the last
> 12 months) it seems worthwhile to decrease the incremental build
> work.
>
> CoDel's header includes net/inet_ecn.h which in turn includes net/sock.h.
> codel.h is itself included by mac80211 which is included by much of
> the WiFi stack and drivers. Removing the net/inet_ecn.h include from
> CoDel breaks the dependecy between WiFi and sock.h.
>
> Commit d068ca2ae2e6 ("codel: split into multiple files") moved all
> the code which actually needs ECN helpers out to net/codel_impl.h,
> the include can be moved there as well.
>
> This decreases the incremental build size after touching sock.h
> from 4999 objects to 4051 objects.
>
> Fix unmasked missing includes in WiFi drivers.
>
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> ---
> CC: kvalo@kernel.org
> CC: pkshih@realtek.com
> CC: ath11k@lists.infradead.org
> CC: linux-wireless@vger.kernel.org
> ---
> drivers/net/wireless/ath/ath11k/debugfs.c | 2 ++
> drivers/net/wireless/realtek/rtw89/core.c | 2 ++
> drivers/net/wireless/realtek/rtw89/debug.c | 2 ++
Acked-by: Kalle Valo <kvalo@kernel.org>
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2021-12-22 5:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-21 19:39 [PATCH net-next 1/2] codel: remove unnecessary sock.h include Jakub Kicinski
2021-12-21 19:39 ` [PATCH net-next 2/2] codel: remove unnecessary pkt_sched.h include Jakub Kicinski
2021-12-22 5:58 ` Kalle Valo
2021-12-22 5:56 ` Kalle Valo [this message]
2021-12-23 0:50 ` [PATCH net-next 1/2] codel: remove unnecessary sock.h include patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sful2ney.fsf@kernel.org \
--to=kvalo@kernel.org \
--cc=ath11k@lists.infradead.org \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkshih@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).