From: Kalle Valo <kvalo@codeaurora.org>
To: vnaralas@codeaurora.org
Cc: Arend Van Spriel <arend.vanspriel@broadcom.com>,
Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org, ath11k@lists.infradead.org
Subject: Re: [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save
Date: Mon, 02 Nov 2020 21:44:01 +0200 [thread overview]
Message-ID: <87sg9rtugu.fsf@codeaurora.org> (raw)
In-Reply-To: <81ced18ac5b87a17cf31797cf91669bc@codeaurora.org> (vnaralas@codeaurora.org's message of "Fri, 23 Oct 2020 09:17:09 +0530")
vnaralas@codeaurora.org writes:
> On 2020-10-22 13:30, Arend Van Spriel wrote:
>> On 10/21/2020 7:19 PM, Kalle Valo wrote:
>>> vnaralas@codeaurora.org writes:
>>>
>>>> On 2020-09-29 13:10, Kalle Valo wrote:
>>>>> Johannes Berg <johannes@sipsolutions.net> writes:
>>>>>
>>>>>> On Mon, 2020-08-24 at 13:56 +0530, Venkateswara Naralasetty wrote:
>>>>>>> AP power save feature is to save power in AP mode, where AP goes
>>>>>>> to power save mode when no stations associate to it and comes out
>>>>>>> of power save when any station associate to AP.
>>>>>>
>>>>>> Why do you think this requires a vendor command? I mean, that seems
>>>>>> like
>>>>>> fairly reasonable - even by default - behaviour?
>>>>>
>>>>> I have not studied the details, but doesn't AP power save break
>>>>> normal
>>>>> functionality? For example, I would guess probe requests from
>>>>> clients
>>>>> would be lost. So there's a major drawback when enabling this,
>>>>> right?
>>>>
>>>> This AP power save feature will not break any functionality, Since
>>>> one
>>>> chain is always active and all other chains will be disabled when
>>>> this
>>>> feature is enabled. AP can still be able to beacon and receive probe
>>>> request from the clients. The only drawback is reduced network range
>>>> when this feature is enabled. Hence, we don't want to enable it by
>>>> default.
>>>
>>> Yeah, we really would not want to enable that by default. But what
>>> should be the path forward, a vendor command or a proper nl80211
>>> command? Any opinions?
>>
>> I would go for a proper nl80211 command or just add an attribute for
>> use in NL80211_CMD_START_AP or deal with NL80211_CMD_SET_POWERSAVE
>> when operating in AP mode.
>>
> Sure, I will go with the existing NL80211_CMD_SET_POWERSAVE and I will
> send next version.
Better to wait first so that we have concensus on this. And need to
check if NL80211_CMD_SET_POWERSAVE is even suitable for AP mode.
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-11-02 19:44 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 8:26 [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save Venkateswara Naralasetty
2020-08-24 8:26 ` [PATCHv2 2/2] ath11k: Add ap power save support Venkateswara Naralasetty
2021-01-27 18:02 ` Kalle Valo
2021-01-27 18:14 ` Kalle Valo
2020-09-28 11:24 ` [PATCHv2 1/2] nl80211: vendor-cmd: qca: add command for ap power save Johannes Berg
2020-09-29 7:40 ` Kalle Valo
2020-09-29 8:04 ` Johannes Berg
2020-09-29 12:39 ` vnaralas
2020-10-21 17:19 ` Kalle Valo
2020-10-22 8:00 ` Arend Van Spriel
2020-10-22 8:05 ` Arend Van Spriel
2020-10-23 3:47 ` vnaralas
2020-11-02 19:44 ` Kalle Valo [this message]
2020-11-06 10:41 ` Johannes Berg
2020-11-17 11:23 ` vnaralas
2020-12-23 12:46 ` Jouni Malinen
2021-01-15 10:10 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sg9rtugu.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=ath11k@lists.infradead.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=vnaralas@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).