From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo@kernel.org>
Cc: nbd@nbd.name, lorenzo.bianconi@redhat.com,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca
Date: Mon, 13 May 2019 15:37:48 +0300 [thread overview]
Message-ID: <87sgtiil7n.fsf@codeaurora.org> (raw)
In-Reply-To: <20190513084127.GA3127@localhost.localdomain> (Lorenzo Bianconi's message of "Mon, 13 May 2019 10:41:28 +0200")
Lorenzo Bianconi <lorenzo@kernel.org> writes:
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>
>> > Introduce a knob in mt7603 debugfs in order to enable/disable
>> > edcca processing
>> >
>> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>>
>> It's good to explain what edcca does and how the file is used supposed
>> to be used. In other words, have a small introduction for the user.
>
> Hi Kalle,
>
> edcca is used for adjusting energy detect based on CCA thresholds.
> The code was already there so I just reported the acronym.
A lot of people read commit logs but not everyone (myself included) are
familiar with mt76 internals so please try to explain the acronyms and
the background of the patch. Also you should explain in the commit log
_why_ you are adding the debugfs file, how it helps the user and how to
use it.
--
Kalle Valo
next prev parent reply other threads:[~2019-05-13 12:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1557591530.git.lorenzo@kernel.org>
2019-05-11 16:38 ` [PATCH] mt76: mt7603: add debugfs knob to enable/disable edcca Lorenzo Bianconi
2019-05-13 4:26 ` Kalle Valo
2019-05-13 8:41 ` Lorenzo Bianconi
2019-05-13 9:48 ` Stanislaw Gruszka
2019-05-15 9:33 ` Stanislaw Gruszka
2019-05-15 9:43 ` Lorenzo Bianconi
2019-05-15 9:54 ` Stanislaw Gruszka
2019-05-15 10:03 ` Lorenzo Bianconi
2019-05-15 10:33 ` Stanislaw Gruszka
2019-05-15 11:13 ` Lorenzo Bianconi
2019-05-15 11:46 ` Stanislaw Gruszka
2019-05-15 12:07 ` Lorenzo Bianconi
2019-05-15 13:48 ` Stanislaw Gruszka
2019-05-15 13:59 ` Stanislaw Gruszka
2019-05-13 12:37 ` Kalle Valo [this message]
2019-05-13 15:41 ` Lorenzo Bianconi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgtiil7n.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).