Re: [PATCH v12] ath10k: add LED and GPIO controlling support for various chipsets

[Kalle Valo <kvalo@codeaurora.org>]

Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:

> Am 06.04.2018 um 10:09 schrieb Kalle Valo:
>> (adding back the lists, please don't top post and trim your quotes)
>>
>> Sebastian Gottschall <s.gottschall@dd-wrt.com> writes:
>>
>>> okay. ath10k-check is buggy and doesnt work. so it doesnt help much
>>> with code styles
>>>
>>> root@seg-desktop:/xfs/ath10k/ath.gpio# ./ath10k-check
>>> global: 'drivers/net/wireless/ath/ath10k/Kconfig' is not a source file.
>>> Traceback (most recent call last):
>>>  =C2=A0 File "./ath10k-check", line 461, in <module>
>>>  =C2=A0=C2=A0=C2=A0 main()
>>>  =C2=A0 File "./ath10k-check", line 455, in main
>>>  =C2=A0=C2=A0=C2=A0 ret =3D run_checkpatch(args)
>>>  =C2=A0 File "./ath10k-check", line 275, in run_checkpatch
>>>  =C2=A0=C2=A0=C2=A0 output =3D subprocess.check_output(cmd, shell=3DTru=
e)
>>>  =C2=A0 File "/usr/lib/python2.7/subprocess.py", line 219, in check_out=
put
>>>  =C2=A0=C2=A0=C2=A0 raise CalledProcessError(retcode, cmd, output=3Dout=
put)
>>> subprocess.CalledProcessError: Command 'global -f
>>> drivers/net/wireless/ath/ath10k/Kconfig' returned non-zero exit status 1
>>
>> You are missing gtags, see 'ath10k-check --help' for how to install:
>>
>> Requirements (all available in $PATH):
>>
>> * gcc
>> * sparse
>> * checkpatch.pl
>> * gtags (from package global)
>
> ahm i did read this and this was all installed. but ath10k-check
> refuses to work
>
> root@seg-desktop:/home/seg/DEV# gtags --version
> gtags (GNU GLOBAL) 6.5.7
> Copyright (c) 1996-2017 Tama Communications Corporation
> License GPLv3+: GNU GPL version 3 or later
> <http://www.gnu.org/licenses/gpl.html>
> This is free software; you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.

Damn, I guess something has changed in gtags as I use older version:

gtags - GNU GLOBAL 5.7.1

--=20
Kalle Valo