From: Kalle Valo <kvalo@codeaurora.org>
To: Daniel Mack <daniel@zonque.org>
Cc: linux-wireless@vger.kernel.org, wcn36xx@lists.infradead.org,
rfried@codeaurora.org, bjorn.andersson@linaro.org
Subject: Re: [PATCH] wcn36xx: allocate skbs with GFP_KERNEL during init
Date: Tue, 03 Apr 2018 12:58:35 +0300 [thread overview]
Message-ID: <87sh8cipbo.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <0dafe1f7-6f79-faa7-aff9-3eca532d237e@zonque.org> (Daniel Mack's message of "Thu, 29 Mar 2018 20:04:10 +0200")
Daniel Mack <daniel@zonque.org> writes:
> On Monday, March 19, 2018 07:30 AM, Daniel Mack wrote:
>> GFP_ATOMIC should only be used when the allocation is done from atomic
>> context. Introduce a new flag to wcn36xx_dxe_fill_skb() and use GFP_KERNEL
>> when pre-allocating buffers during init.
>>
>> This doesn't fix an issue that was observed in the wild, but it reduces
>> the chance of failed allocations under memory pressure.
>>
>> Signed-off-by: Daniel Mack <daniel@zonque.org>
>
> Any opinion about this one?
It's better that you check the state from patchwork, less mail to the
maintainers:
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#checking_state_of_patches_from_patchwork
--
Kalle Valo
next prev parent reply other threads:[~2018-04-03 9:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-19 6:30 [PATCH] wcn36xx: allocate skbs with GFP_KERNEL during init Daniel Mack
2018-03-29 18:04 ` Daniel Mack
2018-04-03 9:58 ` Kalle Valo [this message]
2018-04-10 15:00 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sh8cipbo.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@zonque.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rfried@codeaurora.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).