From: Kalle Valo <kvalo@codeaurora.org>
To: Joe Perches <joe@perches.com>
Cc: "Hauke Mehrtens" <hauke@hauke-m.de>,
"Rafał Miłecki" <zajec5@gmail.com>,
linux-wireless@vger.kernel.org,
"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH] bcma: use bcma_debug and pr_cont in MIPS driver
Date: Thu, 19 Oct 2017 07:19:52 +0300 [thread overview]
Message-ID: <87shefojkn.fsf@codeaurora.org> (raw)
In-Reply-To: <1508377091.6806.32.camel@perches.com> (Joe Perches's message of "Wed, 18 Oct 2017 18:38:11 -0700")
Joe Perches <joe@perches.com> writes:
> On Mon, 2017-10-16 at 23:21 +0200, Hauke Mehrtens wrote:
>> On 10/16/2017 02:54 PM, Rafa=C5=82 Mi=C5=82ecki wrote:
>> > From: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>> >=20
>> > Using bcma_debug gives a device-specific prefix for messages and pr_co=
nt
>> > is a common helper for continuing a line.
>> >=20
>> > Signed-off-by: Rafa=C5=82 Mi=C5=82ecki <rafal@milecki.pl>
>>=20
>> Acked-By: Hauke Mehrtens <hauke@hauke-m.de>
>>=20
>> > ---
>> > drivers/bcma/driver_mips.c | 7 ++++---
>> > 1 file changed, 4 insertions(+), 3 deletions(-)
>> >=20
>> > diff --git a/drivers/bcma/driver_mips.c b/drivers/bcma/driver_mips.c
>> > index 89af807cf29c..5904ef1aa624 100644
>> > --- a/drivers/bcma/driver_mips.c
>> > +++ b/drivers/bcma/driver_mips.c
>> > @@ -184,10 +184,11 @@ static void bcma_core_mips_print_irq(struct bcma=
_device *dev, unsigned int irq)
>> > {
>> > int i;
>> > static const char *irq_name[] =3D {"2(S)", "3", "4", "5", "6", "D", =
"I"};
>> > - printk(KERN_DEBUG KBUILD_MODNAME ": core 0x%04x, irq :", dev->id.id);
>> > +
>> > + bcma_debug(dev->bus, "core 0x%04x, irq :", dev->id.id);
>> > for (i =3D 0; i <=3D 6; i++)
>> > - printk(" %s%s", irq_name[i], i =3D=3D irq ? "*" : " ");
>> > - printk("\n");
>> > + pr_cont(" %s%s", irq_name[i], i =3D=3D irq ? "*" : " ");
>> > + pr_cont("\n");
>> > }
>> >=20=20
>> > static void bcma_core_mips_dump_irq(struct bcma_bus *bus)
>> >=20
>
> This isn't the same code as it depends on #define DEBUG
> and will not output the first line in most cases.
>
> I'd suggest a nack.
Too late, I already applied this. Please submit a followup patch if
something needs to be changed.
--=20
Kalle Valo
next prev parent reply other threads:[~2017-10-19 4:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-16 12:54 [PATCH] bcma: use bcma_debug and pr_cont in MIPS driver Rafał Miłecki
2017-10-16 21:21 ` Hauke Mehrtens
2017-10-19 1:38 ` Joe Perches
2017-10-19 4:19 ` Kalle Valo [this message]
2017-10-19 6:33 ` Rafał Miłecki
2017-10-17 14:23 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shefojkn.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=hauke@hauke-m.de \
--cc=joe@perches.com \
--cc=linux-wireless@vger.kernel.org \
--cc=rafal@milecki.pl \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).