From: Kalle Valo <kvalo@codeaurora.org>
To: David Lin <dlin@marvell.com>
Cc: Johannes Berg <johannes@sipsolutions.net>,
"linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"Chor Teck Law" <ctlaw@marvell.com>,
Pete Hsieh <peteh@marvell.com>
Subject: Re: [PATCH v8] Add new mac80211 driver mwlwifi.
Date: Tue, 04 Oct 2016 20:36:27 +0300 [thread overview]
Message-ID: <87shsc10f8.fsf@purkki.adurom.net> (raw)
In-Reply-To: <fdef0b5d3b744af8be48680e56ae9fb1@SC-EXCH02.marvell.com> (David Lin's message of "Tue, 28 Jun 2016 01:43:36 +0000")
David Lin <dlin@marvell.com> writes:
> PATCH v8 changes since PATCH v7:
>
> - Used scnprintf() to replace sprintf() for debugfs output messages to avoid
> overwriting buffer boundary.
> - Used mutex to replace spinlock for the protection of firmware command.
> - Used NL80211_BAND_XXXX instead of IEEE80211_BAND_XXXX (in order to work with
> updated mac80211).
> - Used usleep_range() instead of mdelay().
> - Modified the code to work with new mac80211 API ampdu_action() and get peer
> AMSDU information from parameters of this function instead of peeking ADDBA
> related packets.
> - Removed BA stream if traffic is not heavy.
> - Removed version information.
> - Added DFS, WPS, WDS and thermal function.
> - Changed length of mac vht_mpdu from 7991 to 3895.
I did a diff against v7 and you are not really making this easy:
drivers/net/wireless/marvell/mwlwifi/Makefile | 3 +-
drivers/net/wireless/marvell/mwlwifi/debugfs.c | 591 ++++++++++++++----
drivers/net/wireless/marvell/mwlwifi/debugfs.h | 8 +-
drivers/net/wireless/marvell/mwlwifi/dev.h | 85 ++-
drivers/net/wireless/marvell/mwlwifi/fwcmd.c | 750 ++++++++++++++++-------
drivers/net/wireless/marvell/mwlwifi/fwcmd.h | 24 +-
drivers/net/wireless/marvell/mwlwifi/fwdl.c | 43 +-
drivers/net/wireless/marvell/mwlwifi/fwdl.h | 8 +-
drivers/net/wireless/marvell/mwlwifi/hostcmd.h | 109 +++-
drivers/net/wireless/marvell/mwlwifi/isr.c | 90 ++-
drivers/net/wireless/marvell/mwlwifi/isr.h | 9 +-
drivers/net/wireless/marvell/mwlwifi/mac80211.c | 74 ++-
drivers/net/wireless/marvell/mwlwifi/main.c | 270 ++++----
drivers/net/wireless/marvell/mwlwifi/rx.c | 149 +----
drivers/net/wireless/marvell/mwlwifi/rx.h | 8 +-
drivers/net/wireless/marvell/mwlwifi/sysadpt.h | 18 +-
drivers/net/wireless/marvell/mwlwifi/thermal.c | 182 ++++++
drivers/net/wireless/marvell/mwlwifi/thermal.h | 40 ++
drivers/net/wireless/marvell/mwlwifi/tx.c | 145 +++--
drivers/net/wireless/marvell/mwlwifi/tx.h | 9 +-
20 files changed, 1799 insertions(+), 816 deletions(-)
You do understand that making so drastic changes during the driver
review is very counterproductive and demotivating for the reviewers?
Before I start looking this again I want to have an assurance that you
have frozen the driver and are not adding new features. I do not want
waste my time again just going circles.
You can continue adding new features but do that as separate patches and
submit them after the driver is applied to wireless-drivers-next.
--
Kalle Valo
next prev parent reply other threads:[~2016-10-04 17:36 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-28 1:43 [PATCH v8] Add new mac80211 driver mwlwifi David Lin
2016-10-04 17:36 ` Kalle Valo [this message]
-- strict thread matches above, loose matches on Subject: below --
2016-06-28 1:44 David Lin
2016-06-29 13:44 Baumann, Christoph (C.)
2016-06-30 1:15 ` David Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shsc10f8.fsf@purkki.adurom.net \
--to=kvalo@codeaurora.org \
--cc=ctlaw@marvell.com \
--cc=dlin@marvell.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=peteh@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox