From: Kalle Valo <kvalo@codeaurora.org>
To: IgorMitsyanko <igor.mitsyanko.os@quantenna.com>
Cc: <johannes@sipsolutions.net>, <linux-wireless@vger.kernel.org>,
"Avinash Patil" <avinashp@quantenna.com>,
Dmitrii Lebed <dlebed@quantenna.com>,
"Sergei Maksimenko" <smaksimenko@quantenna.com>,
Sergey Matyukevich <smatyukevich@quantenna.com>,
Bindu Therthala <btherthala@quantenna.com>,
Huizhao Wang <hwang@quantenna.com>,
Kamlesh Rath <krath@quantenna.com>
Subject: Re: [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets
Date: Mon, 26 Sep 2016 13:45:49 +0300 [thread overview]
Message-ID: <87shsnym5e.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <dfdaca87-dfbd-4677-fbff-45127ccd2e0c@quantenna.com> (IgorMitsyanko's message of "Tue, 20 Sep 2016 22:05:07 +0300")
IgorMitsyanko <igor.mitsyanko.os@quantenna.com> writes:
> On 09/17/2016 04:56 PM, Kalle Valo wrote:
>> <igor.mitsyanko.os@quantenna.com> writes:
>>
>>> +/* FW names */
>>> +
>>> +#define QTN_PCI_FW_NAME "pearl-linux.lzma.img"
>>
>> The firmware name gives no indication what this file is about (remember
>> that linux-firmware.git has a lot of files). Please name it properly,
>> don't just use what is used in by firmware build scripts :) Take into
>> account also future hw support, all firmware files need to coexist in
>> the same repository without user invention. In a way the firmware
>> filename is part of kernel/userspace interface and needs to be stable.
>>
>> For example, you could use something like "qtnfmac/qsr10g.img" (assuming
>> qsr10g is the name of chip).
>
> Ok, we will reconsider our naming conventions, take into account more
> devices that we need to support in the future.
> I'm thinking about something like:
> qtn/fmac_qsr10g.img <---- FullMAC QSR10G device
> qtn/fmac_qsr1000.img <---- FullMAC QSR1000 device
> qtn/smac_qsr10g.img <---- SoftMAC QSR10G
> qtn/smac_qsr10000.img <----- SoftMAC QSR1000
> etc
Looks good to me.
--
Kalle Valo
prev parent reply other threads:[~2016-09-26 10:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 22:11 [PATCH v2 RESEND] qtnfmac: announcement of new FullMAC driver for Quantenna chipsets igor.mitsyanko.os
2016-06-21 2:12 ` kbuild test robot
2016-06-21 12:22 ` Johannes Berg
2016-07-11 18:57 ` Igor Mitsyanko
2016-08-01 9:37 ` Johannes Berg
2016-09-17 13:59 ` Kalle Valo
2016-07-19 7:39 ` [v2, " Kalle Valo
2016-09-17 13:46 ` [PATCH v2 " Kalle Valo
2016-09-17 14:50 ` Johannes Berg
2016-09-17 15:01 ` Kalle Valo
2016-09-17 15:11 ` Johannes Berg
2016-09-17 15:14 ` Kalle Valo
2016-09-20 18:51 ` IgorMitsyanko
2016-09-20 18:51 ` IgorMitsyanko
2016-09-26 10:56 ` Kalle Valo
2016-09-26 12:45 ` IgorMitsyanko
2016-09-26 18:16 ` Kalle Valo
2016-09-17 13:56 ` Kalle Valo
2016-09-20 19:05 ` IgorMitsyanko
2016-09-26 10:45 ` Kalle Valo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shsnym5e.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=avinashp@quantenna.com \
--cc=btherthala@quantenna.com \
--cc=dlebed@quantenna.com \
--cc=hwang@quantenna.com \
--cc=igor.mitsyanko.os@quantenna.com \
--cc=johannes@sipsolutions.net \
--cc=krath@quantenna.com \
--cc=linux-wireless@vger.kernel.org \
--cc=smaksimenko@quantenna.com \
--cc=smatyukevich@quantenna.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).