From: Kalle Valo <kvalo@codeaurora.org>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: Johannes Berg <johannes.berg@intel.com>,
Stanislav Yakovlev <stas.yakovlev@gmail.com>,
linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFC] ipw2200: select CFG80211_WEXT
Date: Tue, 23 Dec 2014 12:50:54 +0200 [thread overview]
Message-ID: <87sig6ej1t.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <1419330055.30945.76.camel@x220> (Paul Bolle's message of "Tue, 23 Dec 2014 11:20:55 +0100")
Paul Bolle <pebolle@tiscali.nl> writes:
> On Tue, 2014-12-23 at 08:52 +0200, Kalle Valo wrote:
>> Paul Bolle <pebolle@tiscali.nl> writes:
>>
>> > Commit 24a0aa212ee2 ("cfg80211: make WEXT compatibility unselectable")
>> > made it impossible to depend on CFG80211_WEXT. It does still allow to
>> > select that symbol. (Yes, the commit summary is confusing.)
>> >
>> > So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be
>> > built again.
>>
>> I think the last sentence is a bit misleading (this isn't a compilation
>> error, right?)
>
> No, it's not a compilation error.
>
> The reasoning here is that all code hidden behind a Kconfig symbol that
> cannot be set will, in practice, never be built. Sure, there are hoops
> one can jump through to try to bypass the generated .config, but no one
> should have to do that.
>
>> and I would like to clarify it like this:
>>
>> "So make IPW2200 select CFG80211_WEXT, so that the ipw2200 driver can be
>> enabled in config again."
>>
>> Does that look ok?
>
> I understand the confusion my text might cause, so I'm fine with your
> amendment.
Thanks for checking. I'll modify the commit log and apply it to
wireless-drivers.git.
--
Kalle Valo
next prev parent reply other threads:[~2014-12-23 10:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 18:10 [PATCH RFC] ipw2200: select CFG80211_WEXT Paul Bolle
2014-12-22 19:13 ` Johannes Berg
2014-12-23 6:52 ` Kalle Valo
2014-12-23 10:20 ` Paul Bolle
2014-12-23 10:50 ` Kalle Valo [this message]
2014-12-23 10:28 ` Johannes Berg
2014-12-23 10:55 ` Kalle Valo
2014-12-24 13:18 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sig6ej1t.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=johannes.berg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pebolle@tiscali.nl \
--cc=stas.yakovlev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).