From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
<ath10k@lists.infradead.org>
Subject: Re: [PATCH/RFT v2 1/4] ath10k: fix add_interface failure handling
Date: Tue, 8 Oct 2013 22:16:51 +0300 [thread overview]
Message-ID: <87siwbr2sc.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQ=qep+rKEyLKrNjNP6K1q+FHKpvkscwXuRMR_45YnRvHA@mail.gmail.com> (Michal Kazior's message of "Tue, 8 Oct 2013 09:49:59 -0700")
Michal Kazior <michal.kazior@tieto.com> writes:
> On 8 October 2013 05:54, Kalle Valo <kvalo@qca.qualcomm.com> wrote:
>> Michal Kazior <michal.kazior@tieto.com> writes:
>>
>>> If something failed along add_interface() setup it
>>> was possible to leak a vdev id, vdev and peer.
>>>
>>> This could end up with leaked FW state or FW crash
>>> (assuming add_interface() failure wasn't a result of
>>> a crash).
>>>
>>> Signed-off-by: Michal Kazior <michal.kazior@tieto.com>
>>
>> Then I apply this patch on top of current ath.git master branch (commit
>> 18fe0b53e76) interface up fails on the managed mode:
>>
>> $ sudo ip link set wlan1 up
>> RTNETLINK answers: Invalid argument
>>
>> Logs don't have anything special (the TX encap error was already
>> before):
>>
>> [ 1259.818863] ath10k: MSI-X didn't succeed (1), trying MSI
>> [ 1259.819298] ath10k_pci 0000:02:00.0: irq 49 for MSI/MSI-X
>> [ 1259.820055] ath10k: MSI interrupt handling
>> [ 1260.747877] ath10k: UART prints disabled
>> [ 1260.828219] ath10k: firmware 10.1.389 booted
>> [ 1260.837585] ath10k: htt target version 2.1
>> [ 1260.838498] ath10k: Failed to set TX encap: -22
>
> Ah. Right. I've tested this patch with main FW branch which supports
> TX encap command. The TX encap issue should be dealth with first.
What do you mean? Did I miss a patch?
--
Kalle Valo
next prev parent reply other threads:[~2013-10-08 19:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-03 13:09 [PATCH/RFT 0/3] ath10k: fixes Michal Kazior
2013-10-03 13:09 ` [PATCH/RFT 1/3] ath10k: fix add_interface failure handling Michal Kazior
2013-10-03 13:09 ` [PATCH/RFT 2/3] ath10k: track vif list internally Michal Kazior
2013-10-03 13:09 ` [PATCH/RFT 3/3] ath10k: fix scheduling while atomic config bug Michal Kazior
2013-10-04 5:43 ` [PATCH/RFT v2 0/4] ath10k: fixes Michal Kazior
2013-10-04 5:43 ` [PATCH/RFT v2 1/4] ath10k: fix add_interface failure handling Michal Kazior
2013-10-08 12:54 ` Kalle Valo
2013-10-08 16:49 ` Michal Kazior
2013-10-08 19:16 ` Kalle Valo [this message]
2013-10-09 2:59 ` Michal Kazior
2013-10-04 5:43 ` [PATCH/RFT v2 2/4] ath10k: track vif list internally Michal Kazior
2013-10-04 5:43 ` [PATCH/RFT v2 3/4] ath10k: fix scheduling while atomic config bug Michal Kazior
2013-10-04 5:43 ` [PATCH/RFT v2 4/4] ath10k: remove unnecessary checks Michal Kazior
2013-10-08 19:17 ` [PATCH/RFT v2 0/4] ath10k: fixes Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87siwbr2sc.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox