From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-wireless@vger.kernel.org,
Jeff Johnson <jjohnson@kernel.org>,
ath10k@lists.infradead.org (open list:QUALCOMM ATHEROS ATH10K
WIRELESS DRIVER), linux-kernel@vger.kernel.org (open list)
Subject: Re: [PATCHv2 ath-next] wifi: ath10k: add nvmem support for mac address
Date: Mon, 18 Aug 2025 09:59:08 +0200 [thread overview]
Message-ID: <87tt2512nn.fsf@bootlin.com> (raw)
In-Reply-To: <20250811203451.3763-1-rosenp@gmail.com> (Rosen Penev's message of "Mon, 11 Aug 2025 13:34:51 -0700")
Hi Rosen,
On 11/08/2025 at 13:34:51 -07, Rosen Penev <rosenp@gmail.com> wrote:
> device_get_mac_address is a generic way to get the MAC address which
> lacks NVMEM support, which tends to be used on embedded platforms.
>
> In case device_get_mac_address fails, try of_get_mac_address_nvmem and
> handle EPROBE_DEFER to wait for the nvmem driver to initialize.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> v2: keep device_get_mac_address and use of_get_mac_address_nvmem
> added Miquel to CC. Maybe he has insight.
LGTM. I guess it is not possible to make this fallback "the default" in
device_get_mac_address()? In this case doing it in your driver seems
fine if it's used on embedded systems with NVMEM cells described to
store MAC addresses.
Cheers,
Miquèl
next prev parent reply other threads:[~2025-08-18 7:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-11 20:34 [PATCHv2 ath-next] wifi: ath10k: add nvmem support for mac address Rosen Penev
2025-08-18 7:59 ` Miquel Raynal [this message]
2025-08-18 19:37 ` Rosen Penev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tt2512nn.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=ath10k@lists.infradead.org \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox