linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] mt76: mt7921: fix mt7921s Kconfig
@ 2021-10-22  9:02 Lorenzo Bianconi
  2021-10-23  7:11 ` Kalle Valo
  2021-10-23  7:28 ` Kalle Valo
  0 siblings, 2 replies; 3+ messages in thread
From: Lorenzo Bianconi @ 2021-10-22  9:02 UTC (permalink / raw)
  To: nbd; +Cc: linux-wireless, lorenzo.bianconi, rdunlap, sean.wang, kvalo

Add missing MMC dependency in mt7921s Kconfig

Fixes: 48fab5bbef409 ("mt76: mt7921: introduce mt7921s support")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Tested-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
 drivers/net/wireless/mediatek/mt76/mt7921/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig b/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig
index ce3a06227901..71154fc2a87c 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/Kconfig
@@ -19,6 +19,7 @@ config MT7921S
 	select MT76_SDIO
 	select MT7921_COMMON
 	depends on MAC80211
+	depends on MMC
 	help
 	  This adds support for MT7921S 802.11ax 2x2:2SS wireless devices.
 
-- 
2.31.1


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] mt76: mt7921: fix mt7921s Kconfig
  2021-10-22  9:02 [PATCH] mt76: mt7921: fix mt7921s Kconfig Lorenzo Bianconi
@ 2021-10-23  7:11 ` Kalle Valo
  2021-10-23  7:28 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-10-23  7:11 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: nbd, linux-wireless, lorenzo.bianconi, rdunlap, sean.wang

Lorenzo Bianconi <lorenzo@kernel.org> writes:

> Add missing MMC dependency in mt7921s Kconfig
>
> Fixes: 48fab5bbef409 ("mt76: mt7921: introduce mt7921s support")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

I had missed this before I submitted the pull request to net-next :(

Felix, I'll take this directly to wireless-drivers-next so that I can
submit the fix to net-next ASAP. Please drop it from your tree.

-- 
https://patchwork.kernel.org/project/linux-wireless/list/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: mt76: mt7921: fix mt7921s Kconfig
  2021-10-22  9:02 [PATCH] mt76: mt7921: fix mt7921s Kconfig Lorenzo Bianconi
  2021-10-23  7:11 ` Kalle Valo
@ 2021-10-23  7:28 ` Kalle Valo
  1 sibling, 0 replies; 3+ messages in thread
From: Kalle Valo @ 2021-10-23  7:28 UTC (permalink / raw)
  To: Lorenzo Bianconi
  Cc: nbd, linux-wireless, lorenzo.bianconi, rdunlap, sean.wang

Lorenzo Bianconi <lorenzo@kernel.org> wrote:

> Add missing MMC dependency in mt7921s Kconfig:
> 
> ld: drivers/net/wireless/mediatek/mt76/sdio.o: in function `mt76s_rr':
> sdio.c:(.text+0x1263): undefined reference to `sdio_claim_host'
> ld: sdio.c:(.text+0x1278): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x12c8): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x1327): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x134d): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x138c): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x140f): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x1498): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x14e5): undefined reference to `sdio_release_host'
> ld: drivers/net/wireless/mediatek/mt76/sdio.o: in function `mt76s_wr':
> sdio.c:(.text+0x1599): undefined reference to `sdio_claim_host'
> ld: sdio.c:(.text+0x15ae): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x15f9): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x1646): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x16a5): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x16cb): undefined reference to `sdio_writel'
> ld: sdio.c:(.text+0x170a): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x1782): undefined reference to `sdio_readl'
> ld: sdio.c:(.text+0x17e9): undefined reference to `sdio_release_host'
> 
> Fixes: 48fab5bbef409 ("mt76: mt7921: introduce mt7921s support")
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Tested-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>

Patch applied to wireless-drivers-next.git, thanks.

8603caaec98f mt76: mt7921: fix mt7921s Kconfig

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/1ce6cb04ba1ab5aabd2b06b45fd8266537ef5359.1634893214.git.lorenzo@kernel.org/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-10-23  7:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-22  9:02 [PATCH] mt76: mt7921: fix mt7921s Kconfig Lorenzo Bianconi
2021-10-23  7:11 ` Kalle Valo
2021-10-23  7:28 ` Kalle Valo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).