From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7461EC4338F for ; Sat, 31 Jul 2021 08:38:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 59AFE60FE7 for ; Sat, 31 Jul 2021 08:38:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232279AbhGaIiv (ORCPT ); Sat, 31 Jul 2021 04:38:51 -0400 Received: from so254-9.mailgun.net ([198.61.254.9]:62565 "EHLO so254-9.mailgun.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229703AbhGaIiu (ORCPT ); Sat, 31 Jul 2021 04:38:50 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1627720724; h=Content-Type: MIME-Version: Message-ID: In-Reply-To: Date: References: Subject: Cc: To: From: Sender; bh=GmmWfCUra51DdcDZI83pLqJ9O3jdxFx8YXjXVt6UXbw=; b=n/b8OGVpUXIehj0Z683Bl6ahWwR/wNd2z3lr0b5XO9msVgDAjVIB76DOXBNfsUA+lmig/Xzh w/6ghibBj6Jdu0zQxjJEM2oWZ4XpMDMeoyYt8WC5sj59me7ktQZau+bqrV6JQdWCf0CdBxij beBOJkSc430qjr2aJA72p0okQ48= X-Mailgun-Sending-Ip: 198.61.254.9 X-Mailgun-Sid: WyI3YTAwOSIsICJsaW51eC13aXJlbGVzc0B2Z2VyLmtlcm5lbC5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n04.prod.us-west-2.postgun.com with SMTP id 61050bfc9771b05b24117f4d (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Sat, 31 Jul 2021 08:38:20 GMT Sender: kvalo=codeaurora.org@mg.codeaurora.org Received: by smtp.codeaurora.org (Postfix, from userid 1001) id BCD6CC433D3; Sat, 31 Jul 2021 08:38:20 +0000 (UTC) Received: from tykki (tynnyri.adurom.net [51.15.11.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo) by smtp.codeaurora.org (Postfix) with ESMTPSA id 98AC2C433D3; Sat, 31 Jul 2021 08:38:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 98AC2C433D3 Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=fail smtp.mailfrom=kvalo@codeaurora.org From: Kalle Valo To: Arnd Bergmann Cc: Felix Fietkau , Lorenzo Bianconi , Arnd Bergmann , Ryder Lee , "David S. Miller" , Jakub Kicinski , Matthias Brugger , Shayne Chen , Sean Wang , Soul Huang , Deren Wu , Xing Song , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mt76: fix enum type mismatch References: <20210721150745.1914829-1-arnd@kernel.org> Date: Sat, 31 Jul 2021 11:38:11 +0300 In-Reply-To: <20210721150745.1914829-1-arnd@kernel.org> (Arnd Bergmann's message of "Wed, 21 Jul 2021 17:06:56 +0200") Message-ID: <87tukaev4c.fsf@codeaurora.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Arnd Bergmann writes: > From: Arnd Bergmann > > There is no 'NONE' version of 'enum mcu_cipher_type', and returning > 'MT_CIPHER_NONE' causes a warning: > > drivers/net/wireless/mediatek/mt76/mt7921/mcu.c: In function 'mt7921_mcu_get_cipher': > drivers/net/wireless/mediatek/mt76/mt7921/mcu.c:114:24: error: implicit conversion from 'enum mt76_cipher_type' to 'enum mcu_cipher_type' [-Werror=enum-conversion] > 114 | return MT_CIPHER_NONE; > | ^~~~~~~~~~~~~~ > > Add the missing MCU_CIPHER_NONE defintion that fits in here with > the same value. > > Fixes: c368362c36d3 ("mt76: fix iv and CCMP header insertion") > Signed-off-by: Arnd Bergmann > --- > This problem currently exists in 5.14-rc2, please ignore my patch > if a fix is already queued up elsewhere. Should I take this to wireless-drivers? Felix, ack? -- https://patchwork.kernel.org/project/linux-wireless/list/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches