From: Kalle Valo <kvalo@codeaurora.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org,
shawn.guo@linaro.org, loic.poulain@linaro.org
Subject: Re: [PATCH v2 01/12] wcn36xx: Add VHT fields to parameter data structures
Date: Wed, 02 Sep 2020 15:19:13 +0300 [thread overview]
Message-ID: <87tuwg4bi6.fsf@codeaurora.org> (raw)
In-Reply-To: <2b2d04fb-14bc-fc6f-9c63-f3cefc4c9a43@linaro.org> (Bryan O'Donoghue's message of "Wed, 2 Sep 2020 10:39:14 +0100")
Bryan O'Donoghue <bryan.odonoghue@linaro.org> writes:
> On 02/09/2020 09:59, Kalle Valo wrote:
>> Bryan O'Donoghue <bryan.odonoghue@linaro.org> wrote:
>>
>>> In order to pass VHT parameters to wcn3680 we need to use a super-set of
>>> the V1 data-structures with additional VHT parameters tacked on.
>>>
>>> This patch adds the additional fields to the STA and BSS parameter
>>> structures with some utility macros to make calculation of the structure
>>> size easier.
>>>
>>> Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
>>
>> New warnings:
>>
>> drivers/net/wireless/ath/wcn36xx/smd.c:1257:1: warning:
>> 'wcn36xx_smd_set_sta_params_v1' defined but not used
>> [-Wunused-function]
>> 1257 | wcn36xx_smd_set_sta_params_v1(struct wcn36xx *wcn,
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/ath/wcn36xx/smd.c:150:1: warning:
>> 'wcn36xx_smd_set_bss_vht_params' defined but not used
>> [-Wunused-function]
>> 150 | wcn36xx_smd_set_bss_vht_params(struct ieee80211_vif *vif,
>> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>
> I'm declaring a series of functions in patches for later use, in
> patches 03-10.
>
> Do you want those squashed into the patch/patches where they are first
> used ?
Yeah, squashing them is better. Every patch should compile on it's own
and be warning free. Kbuild bot will even check that and report if there
are warnings in-between patches.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
next prev parent reply other threads:[~2020-09-02 12:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-29 3:38 [PATCH v2 00/12] wcn36xx: Add support for extended V1 SMD parameter passing Bryan O'Donoghue
2020-08-29 3:38 ` [PATCH v2 01/12] wcn36xx: Add VHT fields to parameter data structures Bryan O'Donoghue
2020-09-02 8:59 ` Kalle Valo
[not found] ` <20200902085942.05A42C433C6@smtp.codeaurora.org>
2020-09-02 9:39 ` Bryan O'Donoghue
2020-09-02 12:19 ` Kalle Valo [this message]
2020-08-29 3:38 ` [PATCH v2 02/12] wcn36xx: Use V1 data structure to store supported rates Bryan O'Donoghue
2020-08-29 3:38 ` [PATCH v2 03/12] wcn36xx: Add wcn36xx_set_default_rates_v1 Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 04/12] wcn36xx: Add VHT rates to wcn36xx_update_allowed_rates() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 05/12] wcn36xx: Add wcn36xx_smd_set_sta_default_vht_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 06/12] wcn36xx: Add wcn36xx_smd_set_sta_default_ht_ldpc_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 07/12] wcn36xx: Add wcn36xx_smd_set_sta_vht_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 08/12] wcn36xx: Add wcn36xx_smd_set_sta_ht_ldpc_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 09/12] wcn36xx: Add wcn36xx_smd_set_bss_vht_params() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 10/12] wcn36xx: Add wrapper function wcn36xx_smd_set_sta_params_v1() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 11/12] wcn36xx: Define INIT_HAL_MSG_V1() Bryan O'Donoghue
2020-08-29 3:39 ` [PATCH v2 12/12] wcn36xx: Convert to VHT parameter structure on wcn3680 Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tuwg4bi6.fsf@codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=bryan.odonoghue@linaro.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=shawn.guo@linaro.org \
--cc=wcn36xx@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).