From: Kalle Valo <kvalo@codeaurora.org>
To: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
Felix Fietkau <nbd@nbd.name>,
linux-wireless <linux-wireless@vger.kernel.org>,
Ryder Lee <ryder.lee@mediatek.com>, Roy Luo <royluo@google.com>,
YF Luo <yf.luo@mediatek.com>
Subject: Re: [PATCH 4/6] mt76: mt7615: unlock dfs bands
Date: Mon, 01 Jul 2019 10:59:22 +0300 [thread overview]
Message-ID: <87tvc69odh.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CAJ0CqmU6TLhFa4ZJxWHBzvpx+5g5E4-WkSPECx47F9d3T=5YjQ@mail.gmail.com> (Lorenzo Bianconi's message of "Sun, 30 Jun 2019 13:25:56 +0200")
Lorenzo Bianconi <lorenzo.bianconi@redhat.com> writes:
>>
>> Lorenzo Bianconi <lorenzo@kernel.org> writes:
>>
>> > Unlock dfs channels since now mt7615 driver supports radar detection
>> >
>> > Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
>> > ---
>> > drivers/net/wireless/mediatek/mt76/mt7615/init.c | 6 ++++++
>> > 1 file changed, 6 insertions(+)
>> >
>> > diff --git a/drivers/net/wireless/mediatek/mt76/mt7615/init.c b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
>> > index 5dc4cced5789..6d336d82cafe 100644
>> > --- a/drivers/net/wireless/mediatek/mt76/mt7615/init.c
>> > +++ b/drivers/net/wireless/mediatek/mt76/mt7615/init.c
>> > @@ -152,6 +152,12 @@ static const struct ieee80211_iface_combination if_comb[] = {
>> > .max_interfaces = 4,
>> > .num_different_channels = 1,
>> > .beacon_int_infra_match = true,
>> > + .radar_detect_widths = BIT(NL80211_CHAN_WIDTH_20_NOHT) |
>> > + BIT(NL80211_CHAN_WIDTH_20) |
>> > + BIT(NL80211_CHAN_WIDTH_40) |
>> > + BIT(NL80211_CHAN_WIDTH_80) |
>> > + BIT(NL80211_CHAN_WIDTH_160) |
>> > + BIT(NL80211_CHAN_WIDTH_80P80),
>>
>> Isn't it questionable to enable these without any testing on real
>> hardware? Getting DFS to work correctly is hard so I'm very suspicious
>> about this.
>>
>> --
>> Kalle Valo
>
> Hi Kalle,
>
> unfortunately at the moment I am not able to run any tests with a real
> signal generator so I just ported the code from vendor sdk.
> I am pretty confident it works since the radar pattern detection is
> done in fw/hw so I guess it has been already tested in the vendor sdk
DFS is really tricky to get it working right, so I'm not easily
convinced :)
> but we can postpone this patch and apply just the rest of the series
> until we have some test results.
Yeah, I think it would be best to drop this patch so that DFS is not
enabled by default and apply this patch only after positive test
results.
--
Kalle Valo
next prev parent reply other threads:[~2019-07-01 7:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-29 10:36 [PATCH 0/6] add hw dfs pattern detector support to mt7615 driver Lorenzo Bianconi
2019-06-29 10:36 ` [PATCH 1/6] mt76: mt7615: introduce mt7615_regd_notifier Lorenzo Bianconi
2019-06-29 10:36 ` [PATCH 2/6] mt76: mt7615: add hw dfs pattern detector support Lorenzo Bianconi
2019-06-29 10:36 ` [PATCH 3/6] mt76: mt7615: do not perform txcalibration before cac is complited Lorenzo Bianconi
2019-06-29 10:36 ` [PATCH 4/6] mt76: mt7615: unlock dfs bands Lorenzo Bianconi
2019-06-30 9:28 ` Kalle Valo
2019-06-30 11:25 ` Lorenzo Bianconi
2019-07-01 7:59 ` Kalle Valo [this message]
2019-07-01 9:57 ` Ryder Lee
2019-07-01 10:49 ` Kalle Valo
2019-06-29 10:36 ` [PATCH 5/6] mt76: mt7615: add csa support Lorenzo Bianconi
2019-06-29 10:36 ` [PATCH 6/6] mt76: mt7615: add radar pattern test knob to debugfs Lorenzo Bianconi
2019-06-29 10:48 ` [PATCH 0/6] add hw dfs pattern detector support to mt7615 driver Lorenzo Bianconi
2019-06-29 15:20 ` Ryder Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvc69odh.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lorenzo.bianconi@redhat.com \
--cc=lorenzo@kernel.org \
--cc=nbd@nbd.name \
--cc=royluo@google.com \
--cc=ryder.lee@mediatek.com \
--cc=yf.luo@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).