From: Kalle Valo <kvalo@codeaurora.org>
To: Govind Singh <govinds@codeaurora.org>, yamada.masahiro@socionext.com
Cc: "linux-wireless\@vger.kernel.org"
<linux-wireless@vger.kernel.org>,
"ath10k\@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module
Date: Tue, 06 Mar 2018 14:41:26 +0200 [thread overview]
Message-ID: <87tvttl6kp.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <d396df1b09da4dd7aa14d6af2c2b2b18@aphydexm01b.ap.qualcomm.com> (Govind Singh's message of "Thu, 1 Mar 2018 10:13:35 +0000")
(Fixed Govind's top posting and adding Masahiro)
>>> WCN3990 is integrated 802.11ac chipset with SNOC bus interface. Add
>>> snoc layer driver registration and associated ops.
>>>
>>> WCN3990 support is not yet complete as cold-boot handshake is done
>>> using qmi(Qualcomm-MSM-Interface) and qmi client support will be added
>>> once qmi framework is available.
>>>
>>> Signed-off-by: Govind Singh <govinds@codeaurora.org>
>>
>> Kbuild bot found an odd problem with this patch:
>>
>> include/linux/dynamic_debug.h:77:14: error: 'KBUILD_MODNAME'
>> undeclared (first use in this function); did you mean 'KBUILD_BASENAME'?
>>
>> Full report:
>>
>> http://lists.infradead.org/pipermail/ath10k/2018-February/010907.html
>>
>> Any ideas? Is this is some unrelated issue or what? This patch is not
>> even touching hif.h or ce.c.
>
> I didn't encountered this issue as in my defconfig only
> CONFIG_ATH10K_SNOC was defined. This problem is coming when we define
> CONFIG_ATH10K_SNOC and CONFIG_ATH10K_PCI simultaneously in defconfig
> and this is known issue when multiple modules share objects(in this
> case ce.o). I saw similar reported problem and found
> https://patchwork.kernel.org/patch/10060825/.
>
> After picking the below change issue is not seen.
Let's ask the kbuild maintainer. Masahiro, any chances of getting this
patch applied anytime soon:
kbuild: define KBUILD_MODNAME even if multiple modules share objects
https://patchwork.kernel.org/patch/10060825/
In ath10k we would need it as otherwise we are not able to link ce.o
both to ath10k_pci.ko and ath10k_snoc.ko. What do you think?
Full discussion and the ath10k patch here:
https://patchwork.kernel.org/patch/10220657/
--
Kalle Valo
next prev parent reply other threads:[~2018-03-06 12:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-15 8:47 [PATCH 01/13] ath10k: platform driver for WCN3990 SNOC WLAN module Govind Singh
2018-03-01 10:06 ` Kalle Valo
2018-03-01 10:13 ` Govind Singh
2018-03-06 12:41 ` Kalle Valo [this message]
2018-03-08 0:25 ` yamada.masahiro
2018-03-10 9:11 ` Kalle Valo
2018-03-23 11:54 ` govinds
2018-04-04 1:56 ` yamada.masahiro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tvttl6kp.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=govinds@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).