From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from wolverine01.qualcomm.com ([199.106.114.254]:17015 "EHLO wolverine01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750893AbdBSQeE (ORCPT ); Sun, 19 Feb 2017 11:34:04 -0500 From: "Valo, Kalle" To: Erik Stromdahl CC: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [RFC v3 0/8] ath10k sdio support Date: Sun, 19 Feb 2017 16:33:55 +0000 Message-ID: <87tw7q2l8v.fsf@qca.qualcomm.com> (sfid-20170219_173408_196609_9E4C2395) References: <1484342771-6160-1-git-send-email-erik.stromdahl@gmail.com> <87fujbhb29.fsf@kamboji.qca.qualcomm.com> <1c87e0d1-1f14-08bb-2a69-650788fba8dc@gmail.com> <877f4ngii5.fsf@kamboji.qca.qualcomm.com> <8737fagu28.fsf@kamboji.qca.qualcomm.com> In-Reply-To: (Erik Stromdahl's message of "Sun, 19 Feb 2017 17:21:43 +0100") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Erik Stromdahl writes: > Ok, I'll do another round of checkpatch before I submit anything. > I couldn't find the script you mentioned though (ath10k-check). Did you check the link I gave you: https://wireless.wiki.kernel.org/en/users/drivers/ath10k/codingstyle#checki= ng_code > Is it some kind of checkpatch wrapper? It runs various tests (gcc, sparse, checkpatch), sets some checkpatch settings (like line length) and filters out warnings we don't care about. > Anyway, I have a few warnings related to 'line over 80 chars' that > is really hard to get rid of (without breaking indentation etc.) so > I won't do anything about those for now. > > Then there are some other warnings about the BIT macro being preferred > over (1 << x). I have used (1 << x) in some files despite the checkpatch > warning in order to keep the patches consistent with the existing code. > I think the best approach is to have a separate round of cleanup-patches > replacing all (1 << x) with BIT(x). These are all disabled by ath10k-check. I think it's easiest that you forget ath10k-check for now and let me fix those in the next round. --=20 Kalle Valo=